foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 15:24:46 -05:00
Code Issues Packages 1 Wiki Activity
denoland-deno/cli/js
History
Marcos Casagrande 2fc5878668
Change URL.port implementation to match WHATWG specifications (#4954) 
Changed `URL.port` implementation to match [WHATWG
specifications](https://url.spec.whatwg.org/#port-state).

This PR matches the behaviour of other browsers:

1.  a `TypeError` must be thrown when passing an URL with an invalid
port to the constructor.

2. When setting an invalid port, using property setter, I haven't found
what should happen in this case, so I mimic **Firefox** & **Node**
behaviour. If an invalid port is set, it will use the previous value.
**Chrome** sets the value to `'0'` if an invalid port is set. I prefer
to keep the previous valid value.  (I can use Chrome's behaviour if you
think it's better, it's a simple value change)

```
url.port = '3000'; // valid
url.port = 'deno'; // invalid
assertEquals(url.port, '3000');
```

3. If the port value equals the current protocol default port value,
`port` will be an empty string.
2020-04-28 01:23:06 -04:00
..
compiler Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
ops Rename FileInfo time fields and represent them as Date objects (#4932) 2020-04-27 21:13:32 +02:00
tests Change URL.port implementation to match WHATWG specifications (#4954) 2020-04-28 01:23:06 -04:00
web Change URL.port implementation to match WHATWG specifications (#4954) 2020-04-28 01:23:06 -04:00
buffer.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
build.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
colors.ts refactor(cli/fmt_errors): Format stack frames in prepareStackTrace() (#4706) 2020-04-11 02:08:11 -04:00
compiler.ts remove bootstrap methods from global scope after bootstrapping (#4869) 2020-04-25 01:03:45 +02:00
core.ts Use globalThis to reference global scope (#3719) 2020-01-20 09:30:30 -05:00
deno.ts BREAKING: Remove Deno.symbols namespace (#4936) 2020-04-28 01:06:03 +02:00
diagnostics.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
diagnostics_util.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
error_stack.ts refactor(core/js_error): Align JSStackFrame with CallSite (#4715) 2020-04-13 10:54:16 -04:00
errors.ts Make writeSync, readSync, seekSync, openSync, isatty proper synchronous syscalls (#4762) 2020-04-15 20:43:19 -04:00
files.ts change type of stdio handles in JS api (#4891) 2020-04-25 01:01:25 +02:00
globals.ts remove bootstrap methods from global scope after bootstrapping (#4869) 2020-04-25 01:03:45 +02:00
internals.ts BREAKING: Remove Deno.symbols namespace (#4936) 2020-04-28 01:06:03 +02:00
io.ts Add buffer size argument to copy (#4907) 2020-04-26 16:25:24 -04:00
lib.deno.ns.d.ts Make Deno.kill unstable (#4950) 2020-04-27 23:36:43 -04:00
lib.deno.shared_globals.d.ts Rewrite streams (#4842) 2020-04-22 10:06:51 -04:00
lib.deno.window.d.ts refactor: Event and EventTarget implementations (#4707) 2020-04-11 11:42:02 -04:00
lib.deno.worker.d.ts feat: support Deno namespace in Worker API (#4784) 2020-04-16 23:40:29 +02:00
main.ts remove bootstrap methods from global scope after bootstrapping (#4869) 2020-04-25 01:03:45 +02:00
net.ts fix(cli/js/net): Make generator return types iterable (#4661) 2020-04-15 12:44:09 +02:00
permissions.ts Add require-await lint rule (#4401) 2020-03-20 09:38:34 -04:00
process.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
rbtree.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
read_file.ts Remove doc strings from cli/js TS files (#4329) 2020-03-13 10:22:22 +01:00
repl.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
runtime.ts Simplify timer with macrotask callback (#4385) 2020-03-19 10:45:28 -04:00
runtime_main.ts BREAKING: Remove Deno.symbols namespace (#4936) 2020-04-28 01:06:03 +02:00
runtime_worker.ts BREAKING: Remove Deno.symbols namespace (#4936) 2020-04-28 01:06:03 +02:00
signals.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
testing.ts BREAKING: remove Deno.runTests() API (#4922) 2020-04-27 14:51:22 +02:00
tls.ts BREAKING CHANGE: rename TLS APIs to camel case (#4888) 2020-04-24 23:29:14 +02:00
util.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
version.ts Update to Prettier 2 and use ES Private Fields (#4498) 2020-03-28 13:03:49 -04:00
write_file.ts BREAKING CHANGE: remove Deno.OpenMode (#4884) 2020-04-25 00:45:55 +02:00