mirror of
https://github.com/denoland/deno.git
synced 2024-12-13 02:52:54 -05:00
ce75e31625
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
69 lines
2.2 KiB
TypeScript
69 lines
2.2 KiB
TypeScript
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
import type { CallbackWithError } from "internal:deno_node/_fs/_fs_common.ts";
|
|
import { getValidatedPath } from "internal:deno_node/internal/fs/utils.mjs";
|
|
import * as pathModule from "internal:deno_node/path.ts";
|
|
import { parseFileMode } from "internal:deno_node/internal/validators.mjs";
|
|
import { Buffer } from "internal:deno_node/buffer.ts";
|
|
import { promisify } from "internal:deno_node/internal/util.mjs";
|
|
|
|
export function chmod(
|
|
path: string | Buffer | URL,
|
|
mode: string | number,
|
|
callback: CallbackWithError,
|
|
) {
|
|
path = getValidatedPath(path).toString();
|
|
|
|
try {
|
|
mode = parseFileMode(mode, "mode");
|
|
} catch (error) {
|
|
// TODO(PolarETech): Errors should not be ignored when Deno.chmod is supported on Windows.
|
|
// https://github.com/denoland/deno_std/issues/2916
|
|
if (Deno.build.os === "windows") {
|
|
mode = 0; // set dummy value to avoid type checking error at Deno.chmod
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
Deno.chmod(pathModule.toNamespacedPath(path), mode).catch((error) => {
|
|
// Ignore NotSupportedError that occurs on windows
|
|
// https://github.com/denoland/deno_std/issues/2995
|
|
if (!(error instanceof Deno.errors.NotSupported)) {
|
|
throw error;
|
|
}
|
|
}).then(
|
|
() => callback(null),
|
|
callback,
|
|
);
|
|
}
|
|
|
|
export const chmodPromise = promisify(chmod) as (
|
|
path: string | Buffer | URL,
|
|
mode: string | number,
|
|
) => Promise<void>;
|
|
|
|
export function chmodSync(path: string | URL, mode: string | number) {
|
|
path = getValidatedPath(path).toString();
|
|
|
|
try {
|
|
mode = parseFileMode(mode, "mode");
|
|
} catch (error) {
|
|
// TODO(PolarETech): Errors should not be ignored when Deno.chmodSync is supported on Windows.
|
|
// https://github.com/denoland/deno_std/issues/2916
|
|
if (Deno.build.os === "windows") {
|
|
mode = 0; // set dummy value to avoid type checking error at Deno.chmodSync
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
try {
|
|
Deno.chmodSync(pathModule.toNamespacedPath(path), mode);
|
|
} catch (error) {
|
|
// Ignore NotSupportedError that occurs on windows
|
|
// https://github.com/denoland/deno_std/issues/2995
|
|
if (!(error instanceof Deno.errors.NotSupported)) {
|
|
throw error;
|
|
}
|
|
}
|
|
}
|