mirror of
https://github.com/denoland/deno.git
synced 2024-12-13 02:52:54 -05:00
ce75e31625
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
21 lines
619 B
TypeScript
21 lines
619 B
TypeScript
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
import type { CallbackWithError } from "internal:deno_node/_fs/_fs_common.ts";
|
|
import { getValidatedFd } from "internal:deno_node/internal/fs/utils.mjs";
|
|
|
|
export function close(fd: number, callback: CallbackWithError) {
|
|
fd = getValidatedFd(fd);
|
|
setTimeout(() => {
|
|
let error = null;
|
|
try {
|
|
Deno.close(fd);
|
|
} catch (err) {
|
|
error = err instanceof Error ? err : new Error("[non-error thrown]");
|
|
}
|
|
callback(error);
|
|
}, 0);
|
|
}
|
|
|
|
export function closeSync(fd: number) {
|
|
fd = getValidatedFd(fd);
|
|
Deno.close(fd);
|
|
}
|