mirror of
https://github.com/denoland/deno.git
synced 2024-12-22 23:34:47 -05:00
ce7dc2be92
Adds support for running npm package lifecycle scripts, opted into via a new `--allow-scripts` flag. With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run lifecycle scripts attached to the given packages. Note at the moment this only works when `nodeModulesDir` is true (using the local resolver). When a package with un-run lifecycle scripts is encountered, we emit a warning suggesting things may not work and to try running lifecycle scripts. Additionally, if a package script implicitly requires `node-gyp` and it's not found on the system, we emit a warning. Extra things in this PR: - Extracted out bits of `task.rs` into a separate module for reuse - Added a couple fields to `process.config` in order to support `node-gyp` (it relies on a few variables being there) - Drive by fix to downloading new npm packages to test registry --- TODO: - [x] validation for allow-scripts args (make sure it looks like an npm package) - [x] make allow-scripts matching smarter - [ ] figure out what issues this closes --- Review notes: - This adds a bunch of deps to our test registry due to using `node-gyp`, so it's pretty noisy
58 lines
1.5 KiB
Rust
58 lines
1.5 KiB
Rust
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
|
|
mod common;
|
|
mod global;
|
|
mod local;
|
|
|
|
use std::path::PathBuf;
|
|
use std::sync::Arc;
|
|
|
|
use deno_npm::NpmSystemInfo;
|
|
use deno_runtime::deno_fs::FileSystem;
|
|
|
|
use crate::args::LifecycleScriptsConfig;
|
|
use crate::args::PackageJsonInstallDepsProvider;
|
|
use crate::util::progress_bar::ProgressBar;
|
|
|
|
pub use self::common::NpmPackageFsResolver;
|
|
|
|
use self::global::GlobalNpmPackageResolver;
|
|
use self::local::LocalNpmPackageResolver;
|
|
|
|
use super::cache::NpmCache;
|
|
use super::cache::TarballCache;
|
|
use super::resolution::NpmResolution;
|
|
|
|
#[allow(clippy::too_many_arguments)]
|
|
pub fn create_npm_fs_resolver(
|
|
fs: Arc<dyn FileSystem>,
|
|
npm_cache: Arc<NpmCache>,
|
|
pkg_json_deps_provider: &Arc<PackageJsonInstallDepsProvider>,
|
|
progress_bar: &ProgressBar,
|
|
resolution: Arc<NpmResolution>,
|
|
tarball_cache: Arc<TarballCache>,
|
|
maybe_node_modules_path: Option<PathBuf>,
|
|
system_info: NpmSystemInfo,
|
|
lifecycle_scripts: LifecycleScriptsConfig,
|
|
) -> Arc<dyn NpmPackageFsResolver> {
|
|
match maybe_node_modules_path {
|
|
Some(node_modules_folder) => Arc::new(LocalNpmPackageResolver::new(
|
|
npm_cache,
|
|
fs,
|
|
pkg_json_deps_provider.clone(),
|
|
progress_bar.clone(),
|
|
resolution,
|
|
tarball_cache,
|
|
node_modules_folder,
|
|
system_info,
|
|
lifecycle_scripts,
|
|
)),
|
|
None => Arc::new(GlobalNpmPackageResolver::new(
|
|
npm_cache,
|
|
fs,
|
|
tarball_cache,
|
|
resolution,
|
|
system_info,
|
|
)),
|
|
}
|
|
}
|