1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-04 17:18:23 -05:00
denoland-deno/tests/unit_node/_fs/_fs_readFile_test.ts
Marvin Hagemeister 50538ba35d
fix(node/fs): missing uv error context for readFile (#27011)
Dart's Node wrapper code in `npm:sass` does string slicing on the thrown
error message which broke because of our missing uv error context.

Code in question:

```js
_systemErrorToFileSystemException0(callback) {
  var error, t1, exception, t2;
  try {
    t1 = callback.call$0();
    return t1;
  } catch (exception) {
    error = A.unwrapException(exception);
    if (!type$.JsSystemError._is(error))
      throw exception;
    t1 = error;
    t2 = J.getInterceptor$x(t1);
    throw A.wrapException(new A.FileSystemException0(J.substring$2$s(t2.get$message(t1), (A.S(t2.get$code(t1)) + ": ").length, J.get$length$asx(t2.get$message(t1)) - (", " + A.S(t2.get$syscall(t1)) + " '" + A.S(t2.get$path(t1)) + "'").length), J.get$path$x(error)));
  }
}
```

Fixes https://github.com/denoland/deno/issues/26994
2024-11-22 22:42:27 +01:00

146 lines
4.4 KiB
TypeScript

// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
import { assertCallbackErrorUncaught } from "../_test_utils.ts";
import { promises, readFile, readFileSync } from "node:fs";
import * as path from "@std/path";
import { assert, assertEquals, assertMatch } from "@std/assert";
const moduleDir = path.dirname(path.fromFileUrl(import.meta.url));
const testData = path.resolve(moduleDir, "testdata", "hello.txt");
Deno.test("readFileSuccess", async function () {
const data = await new Promise((res, rej) => {
readFile(testData, (err, data) => {
if (err) {
rej(err);
}
res(data);
});
});
assert(data instanceof Uint8Array);
assertEquals(new TextDecoder().decode(data as Uint8Array), "hello world");
});
Deno.test("readFileEncodeUtf8Success", async function () {
const data = await new Promise((res, rej) => {
readFile(testData, { encoding: "utf8" }, (err, data) => {
if (err) {
rej(err);
}
res(data);
});
});
assertEquals(typeof data, "string");
assertEquals(data as string, "hello world");
});
Deno.test("readFileEncodeHexSuccess", async function () {
const data = await new Promise((res, rej) => {
readFile(testData, { encoding: "hex" }, (err, data) => {
if (err) {
rej(err);
}
res(data);
});
});
assertEquals(typeof data, "string");
assertEquals(data as string, "68656c6c6f20776f726c64");
});
Deno.test("readFileEncodeBase64Success", async function () {
const data = await new Promise((res, rej) => {
readFile(testData, { encoding: "base64" }, (err, data) => {
if (err) {
rej(err);
}
res(data);
});
});
assertEquals(typeof data, "string");
assertEquals(data as string, "aGVsbG8gd29ybGQ=");
});
Deno.test("readFileEncodingAsString", async function () {
const data = await new Promise((res, rej) => {
readFile(testData, "utf8", (err, data) => {
if (err) {
rej(err);
}
res(data);
});
});
assertEquals(typeof data, "string");
assertEquals(data as string, "hello world");
});
Deno.test("readFileSyncSuccess", function () {
const data = readFileSync(testData);
assert(data instanceof Uint8Array);
assertEquals(new TextDecoder().decode(data as Uint8Array), "hello world");
});
Deno.test("readFileEncodeUtf8Success", function () {
const data = readFileSync(testData, { encoding: "utf8" });
assertEquals(typeof data, "string");
assertEquals(data as string, "hello world");
});
Deno.test("readFileEncodeHexSuccess", function () {
const data = readFileSync(testData, { encoding: "hex" });
assertEquals(typeof data, "string");
assertEquals(data as string, "68656c6c6f20776f726c64");
});
Deno.test("readFileEncodeBase64Success", function () {
const data = readFileSync(testData, { encoding: "base64" });
assertEquals(typeof data, "string");
assertEquals(data as string, "aGVsbG8gd29ybGQ=");
});
Deno.test("readFileEncodeAsString", function () {
const data = readFileSync(testData, "utf8");
assertEquals(typeof data, "string");
assertEquals(data as string, "hello world");
});
Deno.test("[std/node/fs] readFile callback isn't called twice if error is thrown", async () => {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("node:fs", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `import { readFile } from ${JSON.stringify(importUrl)}`,
invocation: `readFile(${JSON.stringify(tempFile)}, `,
async cleanup() {
await Deno.remove(tempFile);
},
});
});
Deno.test("fs.promises.readFile with no arg call rejects with error correctly", async () => {
// @ts-ignore no arg call needs to be supported
await promises.readFile().catch((_e) => {});
});
Deno.test("fs.readFile error message contains path + syscall", async () => {
const path = "/does/not/exist";
const err = await new Promise((resolve) => {
readFile(path, "utf-8", (err) => resolve(err));
});
if (err instanceof Error) {
assert(err.message.includes(path), "Path not found in error message");
assertMatch(err.message, /[,\s]open\s/);
}
});
Deno.test("fs.readFileSync error message contains path + syscall", () => {
const path = "/does/not/exist";
try {
readFileSync(path, "utf-8");
} catch (err) {
if (err instanceof Error) {
assert(err.message.includes(path), "Path not found in error message");
assertMatch(err.message, /[,\s]open\s/);
}
}
});