1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 15:06:54 -05:00
denoland-deno/ops
Andreu Botella 4ee76247bc
fix(ops): disallow memory slices as inputs to async ops (#16738)
In Rust, it is UB if a slice is mutated while borrowed except through
the slice itself, and it is also UB if a mutable slice is read while
borrowed. The op macro allows borrowing an `ArrayBuffer{,View}` as a
memory slice for the duration of an op, but this is not sound for async
ops, since the `ArrayBuffer` could be accessed from JS during the await
points. This PR therefore disallows such automatic borrowing only for
async ops.

Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
2023-01-16 21:35:23 +01:00
..
optimizer_tests fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-16 21:35:23 +01:00
tests/compile_fail fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-16 21:35:23 +01:00
attrs.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
Cargo.toml 1.29.3 (#17395) 2023-01-13 12:17:13 -05:00
deno.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
fast_call.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
lib.rs fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-16 21:35:23 +01:00
optimizer.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
README.md feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30

deno_ops

proc_macro for generating highly optimized V8 functions from Deno ops.

// Declare an op.
#[op(fast)]
pub fn op_add(_: &mut OpState, a: i32, b: i32) -> i32 {
  a + b
}

// Register with an extension.
Extension::builder()
  .ops(vec![op_add::decl()])
  .build();

Performance

The macro can optimize away code, short circuit fast paths and generate a Fast API impl.

Cases where code is optimized away:

  • -> () skips serde_v8 and rv.set calls.
  • -> Result<(), E> skips serde_v8 and rv.set calls for Ok() branch.
  • -> ResourceId or -> [int] types will use specialized method like v8::ReturnValue::set_uint32. A fast path for SMI.
  • -> Result<ResourceId, E> or -> Result<[int], E> types will be optimized like above for the Ok() branch.

Fast calls

The macro will infer and try to auto generate V8 fast API call trait impl for sync ops with:

  • arguments: integers, bool, &mut OpState, &[u8], &mut [u8], &[u32], &mut [u32]
  • return_type: integers, bool

The #[op(fast)] attribute should be used to enforce fast call generation at compile time.

Trait gen for async ops & a ZeroCopyBuf equivalent type is planned and will be added soon.

Wasm calls

The #[op(wasm)] attribute should be used for calls expected to be called from Wasm. This enables the fast call generation and allows seamless WasmMemory integration for generic and fast calls.

#[op(wasm)]
pub fn op_args_get(
  offset: i32,
  buffer_offset: i32,
  memory: Option<&[u8]>, // Must be last parameter. Some(..) when entered from Wasm.
) {
  // ...
}