1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 23:34:47 -05:00
denoland-deno/cli/tests
Marvin Hagemeister 59f419bf41
fix(node/http): remoteAddress and remotePort not being set (#21998)
<!--
Before submitting a PR, please read https://deno.com/manual/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->

Ultimately, it came down to using incorrect property names in the
`FakeSocket` constructor. The values are passed under `remoteAddress`,
not `hostname` and `remotePort` instead of `port`.

Fixes https://github.com/denoland/deno/issues/21980
2024-01-19 13:09:37 +01:00
..
integration feat: Start warning on each use of a deprecated API (#21939) 2024-01-18 23:30:49 +00:00
node_compat chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00
testdata feat: Start warning on each use of a deprecated API (#21939) 2024-01-18 23:30:49 +00:00
unit chore(ext/cache): remove CachePutResource in preparation for resource rewrite (#21949) 2024-01-15 13:14:54 -07:00
unit_node fix(node/http): remoteAddress and remotePort not being set (#21998) 2024-01-19 13:09:37 +01:00
integration_tests.rs chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00