foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity
denoland-deno/ops/optimizer_tests
History
Aapo Alasuutari 04ba709b6e
perf(ops): Remove unnecessary fast call fallback options usage (#17585) 
Currently fast ops will always check for the alignment of a TypedArray
when getting a slice out of them. A match is then done to ensure that
some slice was received and if not a fallback will be requested.

For Uint8Arrays (and WasmMemory which is equivalent to a Uint8Array) the
alignment will always be okay. Rust probably optimises this away for the
most part (since the Uint8Array check is `x % 1 != 0`), but what it
cannot optimise away is the fast ops path's request for fallback options
parameter.

The extra parameter's cost is likely negligible but V8 will need to
check if a fallback was requested and prepare the fallback call just in
case it was. In the future the lack of a fallback may also enable V8 to
much better optimise the result handling.

For V8 created buffers, it seems like all buffers are actually always
guaranteed to be properly aligned: All buffers seem to always be created
8-byte aligned, and creating a 32 bit array or 64 bit array with a
non-aligned offset from an ArrayBuffer is not allowed. Unfortunately,
Deno FFI cannot give the same guarantees, and it is actually possible
for eg. 32 bit arrays to be created unaligned using it. These arrays
work fine (at least on Linux) so it seems like this is not illegal, it
just means that we cannot remove the alignment checking for 32 bit
arrays.
2023-01-29 19:35:08 +05:30
..
async_nop.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
async_nop.out feat(core): Reland support for async ops in realms (#17204) 2023-01-14 14:40:16 +01:00
async_nop.rs feat(ops): implement fast lazy async ops (#16579) 2022-11-11 19:14:53 +05:30
async_result.expected fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-15 07:40:01 +00:00
async_result.out fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-15 07:40:01 +00:00
async_result.rs fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-15 07:40:01 +00:00
callback_options.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
callback_options.out perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
callback_options.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
incompatible_1.expected refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
incompatible_1.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
incompatible_1.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
issue16934.expected fix(ops): disallow auto-borrowing OpState across potential await point (#16952) 2022-12-05 21:40:22 +05:30
issue16934.out feat(core): Reland support for async ops in realms (#17204) 2023-01-14 14:40:16 +01:00
issue16934.rs fix(ops): disallow auto-borrowing OpState across potential await point (#16952) 2022-12-05 21:40:22 +05:30
issue16934_fast.expected fix(ops): disallow auto-borrowing OpState across potential await point (#16952) 2022-12-05 21:40:22 +05:30
issue16934_fast.out feat(core): Reland support for async ops in realms (#17204) 2023-01-14 14:40:16 +01:00
issue16934_fast.rs fix(ops): disallow auto-borrowing OpState across potential await point (#16952) 2022-12-05 21:40:22 +05:30
op_blob_revoke_object_url.expected Revert "feat(ops): Fast zero copy string arguments (#16777)" (#17063) 2022-12-15 15:26:10 +00:00
op_blob_revoke_object_url.out Revert "feat(ops): Fast zero copy string arguments (#16777)" (#17063) 2022-12-15 15:26:10 +00:00
op_blob_revoke_object_url.rs Revert "feat(ops): Fast zero copy string arguments (#16777)" (#17063) 2022-12-15 15:26:10 +00:00
op_state.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
op_state.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
op_state.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
op_state_basic1.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
op_state_basic1.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
op_state_basic1.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
op_state_generics.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
op_state_generics.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
op_state_generics.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
op_state_result.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
op_state_result.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
op_state_result.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
op_state_warning.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
op_state_warning.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
op_state_warning.rs feat(ops): implement fast lazy async ops (#16579) 2022-11-11 19:14:53 +05:30
op_state_with_transforms.expected perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
op_state_with_transforms.out perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
op_state_with_transforms.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
opstate_with_arity.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
opstate_with_arity.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
opstate_with_arity.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
option_arg.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
option_arg.out perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
option_arg.rs perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
param_mut_binding_warning.expected refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
param_mut_binding_warning.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
param_mut_binding_warning.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
raw_ptr.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
raw_ptr.out perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
raw_ptr.rs feat(ops): support raw pointer arguments (#16826) 2022-11-26 20:07:43 +05:30
serde_v8_value.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
serde_v8_value.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
serde_v8_value.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
u64_result.expected refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
u64_result.out chore(ops): increase codegen tests coverage (#16834) 2022-11-27 09:10:31 +05:30
u64_result.rs refactor(ops): Rewrite fast call optimizer and codegen (#16514) 2022-11-10 17:23:31 +05:30
uint8array.expected perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
uint8array.out perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
uint8array.rs perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_result.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_result.out perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_result.rs perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_result2.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_result2.out feat: Stabilize Deno.TcpConn.setNoDelay() and Deno.TcpConn.setKeepAlive() (#17003) 2022-12-14 00:54:11 +01:00
unit_result2.rs feat: Stabilize Deno.TcpConn.setNoDelay() and Deno.TcpConn.setKeepAlive() (#17003) 2022-12-14 00:54:11 +01:00
unit_ret.expected perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_ret.out perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
unit_ret.rs perf(ops): Reenable fast unit result optimization (#16827) 2022-11-27 04:48:17 +00:00
wasm_op.expected perf(ops): Remove unnecessary fast call fallback options usage (#17585) 2023-01-29 19:35:08 +05:30
wasm_op.out feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30
wasm_op.rs feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30