mirror of
https://github.com/denoland/deno.git
synced 2024-11-21 15:04:11 -05:00
a1764f7690
This is a follow-on to the earlier work in reducing string copies, mainly focused on ensuring that ASCII strings are easy to provide to the JS runtime. While we are replacing a 16-byte reference in a number of places with a 24-byte structure (measured via `std::mem::size_of`), the reduction in copies wins out over the additional size of the arguments passed into functions. Benchmarking shows approximately the same if not slightly less wallclock time/instructions retired, but I believe this continues to open up further refactoring opportunities.
122 lines
3 KiB
Rust
122 lines
3 KiB
Rust
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
use bencher::Bencher;
|
|
use deno_core::v8;
|
|
use deno_core::Extension;
|
|
use deno_core::JsRuntime;
|
|
use deno_core::RuntimeOptions;
|
|
|
|
use crate::profiling::is_profiling;
|
|
|
|
pub fn create_js_runtime(setup: impl FnOnce() -> Vec<Extension>) -> JsRuntime {
|
|
JsRuntime::new(RuntimeOptions {
|
|
extensions: setup(),
|
|
module_loader: Some(
|
|
std::rc::Rc::new(deno_core::ExtModuleLoader::default()),
|
|
),
|
|
..Default::default()
|
|
})
|
|
}
|
|
|
|
fn loop_code(iters: u64, src: &str) -> String {
|
|
format!(r#"for(let i=0; i < {iters}; i++) {{ {src} }}"#,)
|
|
}
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub struct BenchOptions {
|
|
pub benching_inner: u64,
|
|
pub profiling_inner: u64,
|
|
pub profiling_outer: u64,
|
|
}
|
|
|
|
impl Default for BenchOptions {
|
|
fn default() -> Self {
|
|
Self {
|
|
benching_inner: 1_000,
|
|
profiling_inner: 1_000,
|
|
profiling_outer: 10_000,
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn bench_js_sync(
|
|
b: &mut Bencher,
|
|
src: &str,
|
|
setup: impl FnOnce() -> Vec<Extension>,
|
|
) {
|
|
bench_js_sync_with(b, src, setup, Default::default())
|
|
}
|
|
|
|
pub fn bench_js_sync_with(
|
|
b: &mut Bencher,
|
|
src: &str,
|
|
setup: impl FnOnce() -> Vec<Extension>,
|
|
opts: BenchOptions,
|
|
) {
|
|
let mut runtime = create_js_runtime(setup);
|
|
let scope = &mut runtime.handle_scope();
|
|
|
|
// Increase JS iterations if profiling for nicer flamegraphs
|
|
let inner_iters = if is_profiling() {
|
|
opts.profiling_inner * opts.profiling_outer
|
|
} else {
|
|
opts.benching_inner
|
|
};
|
|
// Looped code
|
|
let looped_src = loop_code(inner_iters, src);
|
|
|
|
let code = v8::String::new(scope, looped_src.as_ref()).unwrap();
|
|
let script = v8::Script::compile(scope, code, None).unwrap();
|
|
// Run once if profiling, otherwise regular bench loop
|
|
if is_profiling() {
|
|
script.run(scope).unwrap();
|
|
} else {
|
|
b.iter(|| {
|
|
script.run(scope).unwrap();
|
|
});
|
|
}
|
|
}
|
|
|
|
pub fn bench_js_async(
|
|
b: &mut Bencher,
|
|
src: &str,
|
|
setup: impl FnOnce() -> Vec<Extension>,
|
|
) {
|
|
bench_js_async_with(b, src, setup, Default::default())
|
|
}
|
|
|
|
pub fn bench_js_async_with(
|
|
b: &mut Bencher,
|
|
src: &str,
|
|
setup: impl FnOnce() -> Vec<Extension>,
|
|
opts: BenchOptions,
|
|
) {
|
|
let mut runtime = create_js_runtime(setup);
|
|
let tokio_runtime = tokio::runtime::Builder::new_current_thread()
|
|
.enable_all()
|
|
.build()
|
|
.unwrap();
|
|
|
|
// Looped code
|
|
let inner_iters = if is_profiling() {
|
|
opts.profiling_inner
|
|
} else {
|
|
opts.benching_inner
|
|
};
|
|
let looped = loop_code(inner_iters, src);
|
|
// Get a &'static str by leaking -- this is fine because it's benchmarking code
|
|
let src = Box::leak(looped.into_boxed_str());
|
|
if is_profiling() {
|
|
for _ in 0..opts.profiling_outer {
|
|
tokio_runtime.block_on(inner_async(src, &mut runtime));
|
|
}
|
|
} else {
|
|
b.iter(|| {
|
|
tokio_runtime.block_on(inner_async(src, &mut runtime));
|
|
});
|
|
}
|
|
}
|
|
|
|
async fn inner_async(src: &'static str, runtime: &mut JsRuntime) {
|
|
runtime.execute_script_static("inner_loop", src).unwrap();
|
|
runtime.run_event_loop(false).await.unwrap();
|
|
}
|