1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 15:24:46 -05:00
denoland-deno/cli/tools
Kyle Kelley 81d6ea8e11
feat(jupyter-kernel): accept nested objects from display calls (#20537)
Closes #20535.

# Screenshots

## JSON
<img width="779" alt="image"
src="https://github.com/denoland/deno/assets/836375/668bb1a6-3f76-4b36-974e-cdc6c93f94c3">

## Vegalite

<img width="558" alt="image"
src="https://github.com/denoland/deno/assets/836375/a5e70908-6b87-42d8-85c3-1323ad52a00f">

# Implementation

Instead of going the route of recursively getting all the objects under
`application/.*json` keys, I went with `JSON.stringify`ing in denospace
then parsing it from rust. One of the key benefits of serializing and
deserializing is that non-JSON-able entries will get stripped
automatically. This also keeps the code pretty simple.

In the future we should _only_ do this for `application/.*json` keys.

cc @mmastrac
2023-09-17 10:38:52 -06:00
..
bench fix(lsp): include JSON modules in local import completions (#20536) 2023-09-17 07:50:30 +01:00
coverage fix: exclude internal JS files from coverage (#20448) 2023-09-11 13:53:42 +00:00
init fix(init): skip existing files instead of erroring (#20434) 2023-09-12 12:55:26 +02:00
jupyter feat(jupyter-kernel): accept nested objects from display calls (#20537) 2023-09-17 10:38:52 -06:00
repl feat: Add "deno jupyter" subcommand (#20337) 2023-09-16 02:42:09 +02:00
test fix(lsp): include JSON modules in local import completions (#20536) 2023-09-17 07:50:30 +01:00
vendor feat: support import attributes (#20342) 2023-09-07 09:09:16 -04:00
bundle.rs refactor: use "deno_config" crate (#20260) 2023-08-24 11:21:34 +02:00
check.rs refactor: upgrade deno_ast 0.28 and deno_semver 0.4 (#20193) 2023-08-21 09:53:52 +00:00
compile.rs feat(compile): Add --no-terminal to compile command (#17991) 2023-07-28 18:46:26 +03:00
doc.rs Reland "fix(cli): don't store blob and data urls in the module cache" (#18581) 2023-07-02 00:52:30 +02:00
fmt.rs fix: empty include in config file excludes all (#20404) 2023-09-08 15:04:45 +01:00
info.rs feat: support import attributes (#20342) 2023-09-07 09:09:16 -04:00
installer.rs refactor: use "deno_config" crate (#20260) 2023-08-24 11:21:34 +02:00
lint.rs fix(lsp): include JSON modules in local import completions (#20536) 2023-09-17 07:50:30 +01:00
mod.rs feat: Add "deno jupyter" subcommand (#20337) 2023-09-16 02:42:09 +02:00
run.rs Reland "fix(cli): don't store blob and data urls in the module cache" (#18581) 2023-07-02 00:52:30 +02:00
task.rs Reland "feat(lsp): enable via config file detection (#20334)" (#20349) 2023-09-01 21:13:13 +01:00
upgrade.rs chore(cli): remove atty crate (#20275) 2023-08-25 07:43:07 -06:00