mirror of
https://github.com/denoland/deno.git
synced 2024-11-22 15:06:54 -05:00
68782346d0
Currently realms are supported on `deno_core`, but there was no support for async ops anywhere other than the main realm. The main issue is that the `js_recv_cb` callback, which resolves promises corresponding to async ops, was only set for the main realm, so async ops in other realms would never resolve. Furthermore, promise ID's are specific to each realm, which meant that async ops from other realms would result in a wrong promise from the main realm being resolved. This change takes the `ContextState` struct added in #17050, and adds to it a `js_recv_cb` callback for each realm. Combined with the fact that that same PR also added a list of known realms to `JsRuntimeState`, and that #17174 made `OpCtx` instances realm-specific and had them include an index into that list of known realms, this makes it possible to know the current realm in the `queue_async_op` and `queue_fast_async_op` methods, and therefore to send the results of promises for each realm to that realm, and prevent the ID's from getting mixed up. Additionally, since promise ID's are no longer unique to the isolate, having a single set of unrefed ops doesn't work. This change therefore also moves `unrefed_ops` from `JsRuntimeState` to `ContextState`, and adds the lengths of the unrefed op sets for all known realms to get the total number of unrefed ops to compare in the event loop. This PR is a reland of #14734 after it was reverted in #16366, except that `ContextState` and `JsRuntimeState::known_realms` were previously relanded in #17050. Another significant difference with the original PR is passing around an index into `JsRuntimeState::known_realms` instead of a `v8::Global<v8::Context>` to identify the realm, because async op queuing in fast calls cannot call into V8, and therefore cannot have access to V8 globals. This also simplified the implementation of `resolve_async_ops`. Co-authored-by: Luis Malheiro <luismalheiro@gmail.com>
96 lines
3.1 KiB
Text
96 lines
3.1 KiB
Text
#[allow(non_camel_case_types)]
|
|
///Auto-generated by `deno_ops`, i.e: `#[op]`
|
|
///
|
|
///Use `send_stdin::decl()` to get an op-declaration
|
|
///you can include in a `deno_core::Extension`.
|
|
pub struct send_stdin;
|
|
#[doc(hidden)]
|
|
impl send_stdin {
|
|
pub fn name() -> &'static str {
|
|
stringify!(send_stdin)
|
|
}
|
|
pub fn v8_fn_ptr<'scope>() -> deno_core::v8::FunctionCallback {
|
|
use deno_core::v8::MapFnTo;
|
|
Self::v8_func.map_fn_to()
|
|
}
|
|
pub fn decl<'scope>() -> deno_core::OpDecl {
|
|
deno_core::OpDecl {
|
|
name: Self::name(),
|
|
v8_fn_ptr: Self::v8_fn_ptr(),
|
|
enabled: true,
|
|
fast_fn: None,
|
|
is_async: true,
|
|
is_unstable: false,
|
|
is_v8: false,
|
|
argc: 1usize,
|
|
}
|
|
}
|
|
#[inline]
|
|
#[allow(clippy::too_many_arguments)]
|
|
async fn call(state: &mut OpState, v: i32) -> Result<(), anyhow::Error> {
|
|
Ok(())
|
|
}
|
|
pub fn v8_func<'scope>(
|
|
scope: &mut deno_core::v8::HandleScope<'scope>,
|
|
args: deno_core::v8::FunctionCallbackArguments,
|
|
mut rv: deno_core::v8::ReturnValue,
|
|
) {
|
|
use deno_core::futures::FutureExt;
|
|
let ctx = unsafe {
|
|
&*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
|
|
as *const deno_core::_ops::OpCtx)
|
|
};
|
|
let op_id = ctx.id;
|
|
let realm_idx = ctx.realm_idx;
|
|
let promise_id = args.get(0);
|
|
let promise_id = deno_core::v8::Local::<
|
|
deno_core::v8::Integer,
|
|
>::try_from(promise_id)
|
|
.map(|l| l.value() as deno_core::PromiseId)
|
|
.map_err(deno_core::anyhow::Error::from);
|
|
let promise_id: deno_core::PromiseId = match promise_id {
|
|
Ok(promise_id) => promise_id,
|
|
Err(err) => {
|
|
deno_core::_ops::throw_type_error(
|
|
scope,
|
|
format!("invalid promise id: {}", err),
|
|
);
|
|
return;
|
|
}
|
|
};
|
|
let arg_0 = args.get(1usize as i32);
|
|
let arg_0 = match deno_core::serde_v8::from_v8(scope, arg_0) {
|
|
Ok(v) => v,
|
|
Err(err) => {
|
|
let msg = format!(
|
|
"Error parsing args at position {}: {}", 1usize,
|
|
deno_core::anyhow::Error::from(err)
|
|
);
|
|
return deno_core::_ops::throw_type_error(scope, msg);
|
|
}
|
|
};
|
|
let get_class = {
|
|
let state = ::std::cell::RefCell::borrow(&ctx.state);
|
|
state.tracker.track_async(op_id);
|
|
state.get_error_class_fn
|
|
};
|
|
deno_core::_ops::queue_async_op(
|
|
ctx,
|
|
scope,
|
|
false,
|
|
async move {
|
|
let result = Self::call(
|
|
compile_error!("mutable opstate is not supported in async ops"),
|
|
arg_0,
|
|
)
|
|
.await;
|
|
(
|
|
realm_idx,
|
|
promise_id,
|
|
op_id,
|
|
deno_core::_ops::to_op_result(get_class, result),
|
|
)
|
|
},
|
|
);
|
|
}
|
|
}
|