1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-08 15:19:40 -05:00
denoland-deno/runtime
Andreu Botella 5c5f4ea1d6
fix(workers): Don't panic when a worker's parent thread stops running (#12156)
This panic could happen in the following cases:

- A non-fatal error being thrown from a worker, that doesn't terminate
  the worker's execution, but propagates to the main thread without
  being handled, and makes the main thread terminate.
- A nested worker being alive while its parent worker gets terminated.
- A race condition if the main event loop terminates the worker as part
  of its last task, but the worker doesn't fully terminate before the
  main event loop stops running.

This panic happens because a worker's event loop should have pending ops
as long as the worker isn't closed or terminated – but if an event loop
finishes running while it has living workers, its associated
`WorkerThread` structs will be dropped, closing the channels that keep
those ops pending.

This change adds a `Drop` implementation to `WorkerThread`, which
terminates the worker without waiting for a response. This fixes the
panic, and makes it so nested workers are automatically terminated once
any of their ancestors is closed or terminated.

This change also refactors a worker's termination code into a
`WorkerThread::terminate()` method.

Closes #11342.

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2021-09-22 18:02:15 +02:00
..
examples fix(core): prevent multiple main module loading (#12128) 2021-09-18 03:44:53 +02:00
js fix(cli/fmt_errors): Abbreviate long data URLs in stack traces (#12127) 2021-09-18 15:40:04 +02:00
ops fix(workers): Don't panic when a worker's parent thread stops running (#12156) 2021-09-22 18:02:15 +02:00
build.rs feat(fetch): mTLS client certificates for fetch() (#11721) 2021-08-25 14:25:12 +02:00
Cargo.toml chore: bump crate versions for 1.14.1 (#12172) 2021-09-22 06:53:47 +10:00
colors.rs refactor: Remove duplicated colors.rs file (#11990) 2021-09-12 12:04:17 -04:00
errors.rs chore: upgrade Rust to 1.55.0 (#11965) 2021-09-09 21:15:21 -04:00
fs_util.rs fix: do not panic on not found cwd (#10238) 2021-04-21 17:52:00 +02:00
inspector_server.rs refactor: cleanup Inspector and InspectorServer implementations (#11837) 2021-08-25 13:39:23 +02:00
js.rs refactor: unify JavaScript script execution method (#11043) 2021-06-22 01:45:41 +02:00
lib.rs feat(tls): Optionally support loading native certs (#11491) 2021-08-07 14:49:38 +02:00
metrics.rs Remove various unnecessary allow(clippy) declarations (#10971) 2021-06-15 19:22:28 +02:00
permissions.rs fix: permission prompt stuffing on Windows (#11969) 2021-09-14 08:37:27 -04:00
README.md chore: fix decendents in runtime readme (#9718) 2021-03-08 13:23:46 +01:00
tokio_util.rs upgrade: tokio 1.0 (#8779) 2021-01-11 23:50:02 -08:00
web_worker.rs fix(workers): Don't panic when a worker's parent thread stops running (#12156) 2021-09-22 18:02:15 +02:00
worker.rs fix(core): prevent multiple main module loading (#12128) 2021-09-18 03:44:53 +02:00

deno_runtime crate

crates docs

This is a slim version of the Deno CLI which removes typescript integration and various tooling (like lint and doc). Basically only JavaScript execution with Deno's operating system bindings (ops).

Stability

This crate is built using battle-tested modules that were originally in deno crate, however the API of this crate is subject to rapid and breaking changes.

MainWorker

The main API of this crate is MainWorker. MainWorker is a structure encapsulating deno_core::JsRuntime with a set of ops used to implement Deno namespace.

When creating a MainWorker implementors must call MainWorker::bootstrap to prepare JS runtime for use.

MainWorker is highly configurable and allows to customize many of the runtime's properties:

  • module loading implementation
  • error formatting
  • support for source maps
  • support for V8 inspector and Chrome Devtools debugger
  • HTTP client user agent, CA certificate
  • random number generator seed

Worker Web API

deno_runtime comes with support for Worker Web API. The Worker API is implemented using WebWorker structure.

When creating a new instance of MainWorker implementors must provide a callback function that is used when creating a new instance of Worker.

All WebWorker instances are descendents of MainWorker which is responsible for setting up communication with child worker. Each WebWorker spawns a new OS thread that is dedicated solely to that worker.