mirror of
https://github.com/denoland/deno.git
synced 2025-01-09 23:58:23 -05:00
8fc4796ed5
- Fixes an issue on Windows where the `fs.constants.X_OK` flag caused `fs.access` and `fs.promises.access` to incorrectly throw a "permission denied" error - Introduced formatting changes due to the formatting tool - Fixed the issue by always removing the `X_OK` bit from the mode variable m (not sure if it's necessary to check for the presence of it in the `mode` param first?) - Updated unit tests to handle the mentioned constant - `X_OK` bit is ignored in the Node implementation and should behave like `F_OK` fs constants Node documentation: https://nodejs.org/api/fs.html#fsconstants fixes https://github.com/denoland/deno/issues/27405
71 lines
2 KiB
TypeScript
71 lines
2 KiB
TypeScript
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
import * as fs from "node:fs";
|
|
import { assertRejects, assertThrows } from "@std/assert";
|
|
|
|
Deno.test(
|
|
"[node/fs.access] Uses the owner permission when the user is the owner",
|
|
{ ignore: Deno.build.os === "windows" },
|
|
async () => {
|
|
const file = await Deno.makeTempFile();
|
|
try {
|
|
await Deno.chmod(file, 0o600);
|
|
await fs.promises.access(file, fs.constants.R_OK);
|
|
await fs.promises.access(file, fs.constants.W_OK);
|
|
await assertRejects(async () => {
|
|
await fs.promises.access(file, fs.constants.X_OK);
|
|
});
|
|
} finally {
|
|
await Deno.remove(file);
|
|
}
|
|
},
|
|
);
|
|
|
|
Deno.test(
|
|
"[node/fs.access] doesn't reject on windows",
|
|
{ ignore: Deno.build.os !== "windows" },
|
|
async () => {
|
|
const file = await Deno.makeTempFile();
|
|
try {
|
|
await fs.promises.access(file, fs.constants.R_OK);
|
|
await fs.promises.access(file, fs.constants.W_OK);
|
|
await fs.promises.access(file, fs.constants.X_OK);
|
|
await fs.promises.access(file, fs.constants.F_OK);
|
|
} finally {
|
|
await Deno.remove(file);
|
|
}
|
|
},
|
|
);
|
|
|
|
Deno.test(
|
|
"[node/fs.accessSync] Uses the owner permission when the user is the owner",
|
|
{ ignore: Deno.build.os === "windows" },
|
|
() => {
|
|
const file = Deno.makeTempFileSync();
|
|
try {
|
|
Deno.chmodSync(file, 0o600);
|
|
fs.accessSync(file, fs.constants.R_OK);
|
|
fs.accessSync(file, fs.constants.W_OK);
|
|
assertThrows(() => {
|
|
fs.accessSync(file, fs.constants.X_OK);
|
|
});
|
|
} finally {
|
|
Deno.removeSync(file);
|
|
}
|
|
},
|
|
);
|
|
|
|
Deno.test(
|
|
"[node/fs.accessSync] doesn't throw on windows",
|
|
{ ignore: Deno.build.os !== "windows" },
|
|
() => {
|
|
const file = Deno.makeTempFileSync();
|
|
try {
|
|
fs.accessSync(file, fs.constants.R_OK);
|
|
fs.accessSync(file, fs.constants.W_OK);
|
|
fs.accessSync(file, fs.constants.X_OK);
|
|
fs.accessSync(file, fs.constants.F_OK);
|
|
} finally {
|
|
Deno.removeSync(file);
|
|
}
|
|
},
|
|
);
|