mirror of
https://github.com/denoland/deno.git
synced 2024-12-11 01:58:05 -05:00
ab60d9e6a3
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when
using `Object.prototype.isPrototypeOf` to check built-in types.
```js
import vm from "node:vm";
const err = new Error();
const crossErr = vm.runInNewContext(`new Error()`);
console.assert( !(crossErr instanceof Error) );
console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) );
```
This PR changes to check using internal slots solves them.
---
current:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error {}
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
Date {}
```
this PR:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error: message
at <anonymous>:1:1
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
2018-12-10T02:26:59.002Z
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
||
|---|---|---|
| .. | ||
| benches | ||
| 00_infra.js | ||
| 01_dom_exception.js | ||
| 01_mimesniff.js | ||
| 02_event.js | ||
| 02_structured_clone.js | ||
| 02_timers.js | ||
| 03_abort_signal.js | ||
| 04_global_interfaces.js | ||
| 05_base64.js | ||
| 06_streams.js | ||
| 06_streams_types.d.ts | ||
| 08_text_encoding.js | ||
| 09_file.js | ||
| 10_filereader.js | ||
| 12_location.js | ||
| 13_message_port.js | ||
| 14_compression.js | ||
| 15_performance.js | ||
| 16_image_data.js | ||
| blob.rs | ||
| Cargo.toml | ||
| compression.rs | ||
| hr_timer_lock.rs | ||
| internal.d.ts | ||
| lib.deno_web.d.ts | ||
| lib.rs | ||
| message_port.rs | ||
| README.md | ||
| stream_resource.rs | ||
| timers.rs | ||
deno web
Op crate that implements Event, TextEncoder, TextDecoder and File API (https://w3c.github.io/FileAPI).
Testing for text encoding is done via WPT in cli/.