mirror of
https://github.com/denoland/deno.git
synced 2024-12-25 00:29:09 -05:00
8c9d1ba1d7
We didn't honour the `position` options of `fd.read` and `fd.write` because we checked if the buffer is of type `Buffer` instead of just `Uint8Array`. Node does the latter. In doing so I noticed that the file handle id was written to a public property which it definitely shouldn't be. This was probably a typo. Fixes https://github.com/denoland/deno/issues/23707
144 lines
3.3 KiB
TypeScript
144 lines
3.3 KiB
TypeScript
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
|
|
// TODO(petamoriken): enable prefer-primordials for node polyfills
|
|
// deno-lint-ignore-file prefer-primordials
|
|
|
|
import { EventEmitter } from "node:events";
|
|
import { Buffer } from "node:buffer";
|
|
import { promises, read, write } from "node:fs";
|
|
import {
|
|
BinaryOptionsArgument,
|
|
FileOptionsArgument,
|
|
ReadOptions,
|
|
TextOptionsArgument,
|
|
} from "ext:deno_node/_fs/_fs_common.ts";
|
|
import { core } from "ext:core/mod.js";
|
|
|
|
interface WriteResult {
|
|
bytesWritten: number;
|
|
buffer: Buffer | string;
|
|
}
|
|
|
|
interface ReadResult {
|
|
bytesRead: number;
|
|
buffer: Buffer;
|
|
}
|
|
|
|
export class FileHandle extends EventEmitter {
|
|
#rid: number;
|
|
constructor(rid: number) {
|
|
super();
|
|
this.#rid = rid;
|
|
}
|
|
|
|
get fd() {
|
|
return this.#rid;
|
|
}
|
|
|
|
read(
|
|
buffer: Uint8Array,
|
|
offset?: number,
|
|
length?: number,
|
|
position?: number | null,
|
|
): Promise<ReadResult>;
|
|
read(options?: ReadOptions): Promise<ReadResult>;
|
|
read(
|
|
bufferOrOpt: Uint8Array | ReadOptions,
|
|
offset?: number,
|
|
length?: number,
|
|
position?: number | null,
|
|
): Promise<ReadResult> {
|
|
if (bufferOrOpt instanceof Uint8Array) {
|
|
return new Promise((resolve, reject) => {
|
|
read(
|
|
this.fd,
|
|
bufferOrOpt,
|
|
offset,
|
|
length,
|
|
position,
|
|
(err, bytesRead, buffer) => {
|
|
if (err) reject(err);
|
|
else resolve({ buffer: buffer, bytesRead: bytesRead });
|
|
},
|
|
);
|
|
});
|
|
} else {
|
|
return new Promise((resolve, reject) => {
|
|
read(this.fd, bufferOrOpt, (err, bytesRead, buffer) => {
|
|
if (err) reject(err);
|
|
else resolve({ buffer: buffer, bytesRead: bytesRead });
|
|
});
|
|
});
|
|
}
|
|
}
|
|
|
|
readFile(
|
|
opt?: TextOptionsArgument | BinaryOptionsArgument | FileOptionsArgument,
|
|
): Promise<string | Buffer> {
|
|
return promises.readFile(this, opt);
|
|
}
|
|
|
|
write(
|
|
buffer: Buffer,
|
|
offset: number,
|
|
length: number,
|
|
position: number,
|
|
): Promise<WriteResult>;
|
|
write(
|
|
str: string,
|
|
position: number,
|
|
encoding: string,
|
|
): Promise<WriteResult>;
|
|
write(
|
|
bufferOrStr: Uint8Array | string,
|
|
offsetOrPosition: number,
|
|
lengthOrEncoding: number | string,
|
|
position?: number,
|
|
): Promise<WriteResult> {
|
|
if (bufferOrStr instanceof Uint8Array) {
|
|
const buffer = bufferOrStr;
|
|
const offset = offsetOrPosition;
|
|
const length = lengthOrEncoding;
|
|
|
|
return new Promise((resolve, reject) => {
|
|
write(
|
|
this.fd,
|
|
buffer,
|
|
offset,
|
|
length,
|
|
position,
|
|
(err, bytesWritten, buffer) => {
|
|
if (err) reject(err);
|
|
else resolve({ buffer, bytesWritten });
|
|
},
|
|
);
|
|
});
|
|
} else {
|
|
const str = bufferOrStr;
|
|
const position = offsetOrPosition;
|
|
const encoding = lengthOrEncoding;
|
|
|
|
return new Promise((resolve, reject) => {
|
|
write(
|
|
this.fd,
|
|
str,
|
|
position,
|
|
encoding,
|
|
(err, bytesWritten, buffer) => {
|
|
if (err) reject(err);
|
|
else resolve({ buffer, bytesWritten });
|
|
},
|
|
);
|
|
});
|
|
}
|
|
}
|
|
|
|
close(): Promise<void> {
|
|
// Note that Deno.close is not async
|
|
return Promise.resolve(core.close(this.fd));
|
|
}
|
|
}
|
|
|
|
export default {
|
|
FileHandle,
|
|
};
|