mirror of
https://github.com/denoland/deno.git
synced 2024-11-24 15:19:26 -05:00
7847de0974
This PR optimizes `addEventListener` by replacing
`webidl.createDictionaryConverter("AddEventListenerOptions", ...)` with
a custom options parsing function to avoid the overhead of `webidl`
methods
**this PR**
```
cpu: 13th Gen Intel(R) Core(TM) i9-13900H
runtime: deno 1.36.1 (x86_64-unknown-linux-gnu)
benchmark time (avg) iter/s (min … max) p75 p99 p995
---------------------------------------------------------------------------------------------------- -----------------------------
addEventListener options converter (undefined) 4.87 ns/iter 205,248,660.8 (4.7 ns … 13.18 ns) 4.91 ns 5.4 ns 5.6 ns
addEventListener options converter (signal) 13.02 ns/iter 76,782,031.2 (11.74 ns … 18.84 ns) 13.08 ns 16.22 ns 16.57 ns
```
**main**
```
cpu: 13th Gen Intel(R) Core(TM) i9-13900H
runtime: deno 1.36.1 (x86_64-unknown-linux-gnu)
benchmark time (avg) iter/s (min … max) p75 p99 p995
---------------------------------------------------------------------------------------------------- -----------------------------
addEventListener options converter (undefined) 108.36 ns/iter 9,228,688.6 (103.5 ns … 129.88 ns) 109.69 ns 115.61 ns 125.28 ns
addEventListener options converter (signal) 134.03 ns/iter 7,460,878.1 (129.14 ns … 144.54 ns) 135.68 ns 141.13 ns 144.1 ns
```
```js
const tg = new EventTarget();
const signal = new AbortController().signal;
Deno.bench("addEventListener options converter (undefined)", () => {
tg.addEventListener("foo", null); // null callback to only bench options converter
});
Deno.bench("addEventListener options converter (signal)", () => {
tg.addEventListener("foo", null, { signal });
});
```
Towards https://github.com/denoland/deno/issues/20167
|
||
|---|---|---|
| .. | ||
| benches | ||
| 00_infra.js | ||
| 01_dom_exception.js | ||
| 01_mimesniff.js | ||
| 02_event.js | ||
| 02_structured_clone.js | ||
| 02_timers.js | ||
| 03_abort_signal.js | ||
| 04_global_interfaces.js | ||
| 05_base64.js | ||
| 06_streams.js | ||
| 06_streams_types.d.ts | ||
| 08_text_encoding.js | ||
| 09_file.js | ||
| 10_filereader.js | ||
| 12_location.js | ||
| 13_message_port.js | ||
| 14_compression.js | ||
| 15_performance.js | ||
| blob.rs | ||
| Cargo.toml | ||
| compression.rs | ||
| hr_timer_lock.rs | ||
| internal.d.ts | ||
| lib.deno_web.d.ts | ||
| lib.rs | ||
| message_port.rs | ||
| README.md | ||
| stream_resource.rs | ||
| timers.rs | ||
deno web
Op crate that implements Event, TextEncoder, TextDecoder and File API (https://w3c.github.io/FileAPI).
Testing for text encoding is done via WPT in cli/.