mirror of
https://github.com/denoland/deno.git
synced 2024-12-25 08:39:09 -05:00
b50691efed
This PR makes json_op_sync/async generic to all Deserialize/Serialize types instead of the loosely-typed serde_json::Value. Since serde_json::Value implements Deserialize/Serialize, very little existing code needs to be updated, however as json_op_sync/async are now generic, type inference is broken in some cases (see cli/build.rs:146). I've found this reduces a good bit of boilerplate, as seen in the updated deno_core examples. This change may also reduce serialization and deserialization overhead as serde has a better idea of what types it is working with. I am currently working on benchmarks to confirm this and I will update this PR with my findings.
32 lines
1.1 KiB
TypeScript
32 lines
1.1 KiB
TypeScript
import { assertMatch, assertStrictEquals, unitTest } from "./test_util.ts";
|
|
|
|
declare global {
|
|
// deno-lint-ignore no-namespace
|
|
namespace Deno {
|
|
// deno-lint-ignore no-explicit-any
|
|
var core: any; // eslint-disable-line no-var
|
|
}
|
|
}
|
|
|
|
unitTest(function malformedJsonControlBuffer(): void {
|
|
const opId = Deno.core.ops()["op_open_sync"];
|
|
const argsBuf = new Uint8Array([1, 2, 3, 4, 5]);
|
|
const resBuf = Deno.core.send(opId, argsBuf);
|
|
const resText = new TextDecoder().decode(resBuf);
|
|
const resObj = JSON.parse(resText);
|
|
assertStrictEquals(resObj.ok, undefined);
|
|
assertStrictEquals(resObj.err.className, "SyntaxError");
|
|
assertMatch(resObj.err.message, /\bexpected value\b/);
|
|
});
|
|
|
|
unitTest(function invalidPromiseId(): void {
|
|
const opId = Deno.core.ops()["op_open_async"];
|
|
const reqBuf = new Uint8Array([0, 0, 0, 0, 0, 0, 0]);
|
|
const resBuf = Deno.core.send(opId, reqBuf);
|
|
const resText = new TextDecoder().decode(resBuf);
|
|
const resObj = JSON.parse(resText);
|
|
console.error(resText);
|
|
assertStrictEquals(resObj.ok, undefined);
|
|
assertStrictEquals(resObj.err.className, "TypeError");
|
|
assertMatch(resObj.err.message, /\bpromiseId\b/);
|
|
});
|