mirror of
https://github.com/denoland/deno.git
synced 2024-11-22 15:06:54 -05:00
2164f6b1eb
Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params).
Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple:
```
opSync("op_foo", param1, param2);
// -> turns to
ops.op_foo(param1, param2);
```
This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path.
Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader.
53 lines
1.2 KiB
TypeScript
53 lines
1.2 KiB
TypeScript
import { assert, assertStringIncludes, unreachable } from "./test_util.ts";
|
|
|
|
Deno.test(async function sendAsyncStackTrace() {
|
|
const buf = new Uint8Array(10);
|
|
const rid = 10;
|
|
try {
|
|
await Deno.read(rid, buf);
|
|
unreachable();
|
|
} catch (error) {
|
|
assert(error instanceof Error);
|
|
const s = error.stack?.toString();
|
|
assert(s);
|
|
console.log(s);
|
|
assertStringIncludes(s, "opcall_test.ts");
|
|
assertStringIncludes(s, "read");
|
|
assert(
|
|
!s.includes("deno:core"),
|
|
"opcall stack traces should NOT include deno:core internals such as unwrapOpResult",
|
|
);
|
|
}
|
|
});
|
|
|
|
declare global {
|
|
namespace Deno {
|
|
// deno-lint-ignore no-explicit-any, no-var
|
|
var core: any;
|
|
}
|
|
}
|
|
|
|
Deno.test(async function opsAsyncBadResource() {
|
|
try {
|
|
const nonExistingRid = 9999;
|
|
await Deno.core.read(
|
|
nonExistingRid,
|
|
new Uint8Array(0),
|
|
);
|
|
} catch (e) {
|
|
if (!(e instanceof Deno.errors.BadResource)) {
|
|
throw e;
|
|
}
|
|
}
|
|
});
|
|
|
|
Deno.test(function opsSyncBadResource() {
|
|
try {
|
|
const nonExistingRid = 9999;
|
|
Deno.core.ops.op_read_sync(nonExistingRid, new Uint8Array(0));
|
|
} catch (e) {
|
|
if (!(e instanceof Deno.errors.BadResource)) {
|
|
throw e;
|
|
}
|
|
}
|
|
});
|