1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
denoland-deno/tests/unit_node/_fs/_fs_close_test.ts
Bartek Iwańczuk 52fb6582e7
test: run node_unit_tests with DENO_FUTURE=1 (#25285)
This is blocking https://github.com/denoland/deno/pull/25213.

Turns out a bunch of FS APIs are completely broken because they
use RIDs (resource IDs) instead of FDs (file descriptors).
2024-08-29 00:09:06 +00:00

100 lines
2.7 KiB
TypeScript

// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
import { assert, assertThrows, fail } from "@std/assert";
import { assertCallbackErrorUncaught } from "../_test_utils.ts";
import { close, closeSync } from "node:fs";
Deno.test({
name: "ASYNC: File is closed",
// TODO(bartlomieju): this test is broken in Deno 2, because `file.rid` is undefined.
// The fs APIs should be rewritten to use actual FDs, not RIDs
ignore: true,
async fn() {
const tempFile: string = await Deno.makeTempFile();
const file: Deno.FsFile = await Deno.open(tempFile);
await new Promise<void>((resolve, reject) => {
close(file.rid, (err) => {
if (err !== null) reject();
else resolve();
});
})
.catch(() => fail("No error expected"))
.finally(async () => {
await Deno.remove(tempFile);
});
},
});
Deno.test({
name: "ASYNC: Invalid fd",
fn() {
assertThrows(() => {
close(-1, (_err) => {});
}, RangeError);
},
});
Deno.test({
name: "close callback should be asynchronous",
// TODO(bartlomieju): this test is broken in Deno 2, because `file.rid` is undefined.
// The fs APIs should be rewritten to use actual FDs, not RIDs
ignore: true,
async fn() {
const tempFile: string = Deno.makeTempFileSync();
const file: Deno.FsFile = Deno.openSync(tempFile);
let foo: string;
const promise = new Promise<void>((resolve) => {
close(file.rid, () => {
assert(foo === "bar");
resolve();
});
foo = "bar";
});
await promise;
Deno.removeSync(tempFile);
},
});
Deno.test({
name: "SYNC: File is closed",
// TODO(bartlomieju): this test is broken in Deno 2, because `file.rid` is undefined.
// The fs APIs should be rewritten to use actual FDs, not RIDs
ignore: true,
fn() {
const tempFile: string = Deno.makeTempFileSync();
const file: Deno.FsFile = Deno.openSync(tempFile);
closeSync(file.rid);
Deno.removeSync(tempFile);
},
});
Deno.test({
name: "SYNC: Invalid fd",
fn() {
assertThrows(() => closeSync(-1));
},
});
Deno.test({
name: "[std/node/fs] close callback isn't called twice if error is thrown",
// TODO(bartlomieju): this test is broken in Deno 2, because `file.rid` is undefined.
// The fs APIs should be rewritten to use actual FDs, not RIDs
ignore: true,
}, async () => {
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("node:fs", import.meta.url);
await assertCallbackErrorUncaught({
prelude: `
import { close } from ${JSON.stringify(importUrl)};
const file = await Deno.open(${JSON.stringify(tempFile)});
`,
invocation: "close(file.rid, ",
async cleanup() {
await Deno.remove(tempFile);
},
});
});