1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-25 16:49:18 -05:00
denoland-deno/core
Nayeem Rahman 806671af33
fix(core): preserve syntax error locations in dynamic imports (#18664)
Fixes #6259.

Adds the location for v8 syntax errors to the message (`message += " at
{location}"`) when rethrowing them for dynamic imports.

Discussing with @bartlomieju on discord I proposed just preserving v8's
error and not reconstructing it, allowing the standard stack trace to
just point to the syntax error instead of the dynamic import. But on
further thought this way has parity with SWC's syntax errors + has the
advantage of showing both the syntax error and dynamic import location.

```ts
// temp.js
await import("./temp2.js");

// temp2.js
function foo() {
  await Promise.resolve();
}

// Before:
// error: Uncaught (in promise) SyntaxError: Unexpected reserved word
// await import("./temp2.js");
// ^
//     at async file:///.../temp.js:1:1

// After:
// error: Uncaught (in promise) SyntaxError: Unexpected reserved word at file:///.../temp2.js:2:3
// await import("./temp2.js");
// ^
//     at async file:///.../temp.js:1:1
```
2023-04-12 13:45:36 +02:00
..
examples refactor(core): Improve ergonomics of managing ASCII strings (#18498) 2023-04-04 06:46:31 -06:00
00_primordials.js fix(core): SafePromiseAll to be unaffected by Array#@@iterator (#17542) 2023-03-13 19:24:31 +09:00
01_core.js feat(core): sync io ops in core (#18603) 2023-04-06 00:14:16 +02:00
02_error.js fix(core): Add lint check for core (#17223) 2023-01-26 16:56:42 +05:30
async_cancel.rs refactor(cli,core,ext,rt): remove some unnecessary clone or malloc (#17274) 2023-01-05 14:29:50 -05:00
async_cell.rs docs: fix minor typo in AsyncRefCell comment (#17732) 2023-02-11 02:11:16 +00:00
bindings.rs fix(core): preserve syntax error locations in dynamic imports (#18664) 2023-04-12 13:45:36 +02:00
Cargo.toml chore: forward v1.32.3 release commit to main (#18561) 2023-04-01 20:27:53 -04:00
encode_decode_test.js chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
error.rs fix(core): preserve syntax error locations in dynamic imports (#18664) 2023-04-12 13:45:36 +02:00
error_builder_test.js chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
error_codes.rs fix: add WouldBlock error (#17339) 2023-02-12 23:14:33 +01:00
extensions.rs refactor(core): Improve ergonomics of managing ASCII strings (#18498) 2023-04-04 06:46:31 -06:00
fast_string.rs refactor(core): Improve ergonomics of managing ASCII strings (#18498) 2023-04-04 06:46:31 -06:00
flags.rs chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
gotham_state.rs Revert "feat(core): prevent isolate drop for CLI main worker (#18059)" (#18157) 2023-03-13 12:58:17 +00:00
icudtl.dat chore: upgrade rusty_v8 to 0.62.2 (#17604) 2023-02-07 13:36:41 +01:00
inspector.rs chore: upgrade rusty_v8 to 0.62.2 (#17604) 2023-02-07 13:36:41 +01:00
internal.d.ts chore: Turn back on dlintPreferPrimordials (#17715) 2023-04-02 19:41:41 +02:00
io.rs chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
lib.deno_core.d.ts feat(core): sync io ops in core (#18603) 2023-04-06 00:14:16 +02:00
lib.rs cleanup(core): Move JsRealm into a separate module (#18641) 2023-04-08 17:00:02 +02:00
module_specifier.rs refactor: deno_core not using std::env::current_dir (#18173) 2023-03-14 16:47:09 -04:00
modules.rs refactor(core): Improve ergonomics of managing ASCII strings (#18498) 2023-04-04 06:46:31 -06:00
normalize_path.rs chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
ops.rs perf: const op declaration (#18288) 2023-03-31 14:42:14 +02:00
ops_builtin.rs feat(core): sync io ops in core (#18603) 2023-04-06 00:14:16 +02:00
ops_builtin_v8.rs feat(core) deno_core::extension! macro to simplify extension registration (#18210) 2023-03-17 18:22:15 +00:00
ops_metrics.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-14 23:18:58 -05:00
README.md chore(core): remove core.opSync (#16379) 2022-10-21 19:35:23 +05:30
realm.rs cleanup(core): Move JsRealm into a separate module (#18641) 2023-04-08 17:00:02 +02:00
resources.rs feat(core): sync io ops in core (#18603) 2023-04-06 00:14:16 +02:00
runtime.rs cleanup(core): Move JsRealm into a separate module (#18641) 2023-04-08 17:00:02 +02:00
serialize_deserialize_test.js chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
snapshot_util.rs Reland "perf(core): preserve ops between snapshots (#18080)" (#18272) 2023-03-18 18:30:04 -04:00
source_map.rs chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
task_queue.rs refactor: remove Semaphore::new(1) and use TaskQueue (#18014) 2023-03-04 20:07:11 -05:00

Deno Core Crate

crates docs

The main dependency of this crate is rusty_v8, which provides the V8-Rust bindings.

This Rust crate contains the essential V8 bindings for Deno's command-line interface (Deno CLI). The main abstraction here is the JsRuntime which provides a way to execute JavaScript.

The JsRuntime implements an event loop abstraction for the executed code that keeps track of all pending tasks (async ops, dynamic module loads). It is user's responsibility to drive that loop by using JsRuntime::run_event_loop method - it must be executed in the context of Rust's future executor (eg. tokio, smol).

Rust functions can be registered in JavaScript using deno_core::Extension. Use the Deno.core.ops.op_name() and Deno.core.opAsync("op_name", ...) functions to trigger the op function callback. A conventional way to write ops is using the deno_ops crate.

Documentation for this crate is thin at the moment. Please see hello_world.rs and http_bench_json_ops.rs as examples of usage.

TypeScript support and lots of other functionality are not available at this layer. See the CLI for that.