mirror of
https://github.com/denoland/deno.git
synced 2024-12-12 02:27:46 -05:00
ce75e31625
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
8 lines
395 B
Text
8 lines
395 B
Text
error: Uncaught (in worker "") Error
|
|
throw new Error();
|
|
^
|
|
at [WILDCARD]/workers/drop_handle_race.js:2:9
|
|
at Object.action (internal:deno_web/02_timers.js:[WILDCARD])
|
|
at handleTimerMacrotask (internal:deno_web/02_timers.js:[WILDCARD])
|
|
error: Uncaught (in promise) Error: Unhandled error in child worker.
|
|
at Worker.#pollControl (internal:runtime/11_workers.js:[WILDCARD])
|