1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-11 10:07:54 -05:00
denoland-deno/ext/node/polyfills/_fs/_fs_utimes.ts
Bartek Iwańczuk ce75e31625 refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten 
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`. 
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in: 
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and 
in some cases might result in a significant size difference for the 
snapshot. As an example, in "deno_node" extension, we store the 
source code in "polyfills" directory; which resulted in each specifier 
to look like "internal:deno_node/polyfills/<module_name>", but with 
this change it's "internal:deno_node/<module_name>". 

Given that "deno_node" has over 100 files, many of them having 
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
2023-03-10 12:47:26 +09:00

61 lines
1.5 KiB
TypeScript

// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import type { CallbackWithError } from "internal:deno_node/_fs/_fs_common.ts";
import { fromFileUrl } from "internal:deno_node/path.ts";
import { promisify } from "internal:deno_node/internal/util.mjs";
function getValidTime(
time: number | string | Date,
name: string,
): number | Date {
if (typeof time === "string") {
time = Number(time);
}
if (
typeof time === "number" &&
(Number.isNaN(time) || !Number.isFinite(time))
) {
throw new Deno.errors.InvalidData(
`invalid ${name}, must not be infinity or NaN`,
);
}
return time;
}
export function utimes(
path: string | URL,
atime: number | string | Date,
mtime: number | string | Date,
callback: CallbackWithError,
) {
path = path instanceof URL ? fromFileUrl(path) : path;
if (!callback) {
throw new Deno.errors.InvalidData("No callback function supplied");
}
atime = getValidTime(atime, "atime");
mtime = getValidTime(mtime, "mtime");
Deno.utime(path, atime, mtime).then(() => callback(null), callback);
}
export const utimesPromise = promisify(utimes) as (
path: string | URL,
atime: number | string | Date,
mtime: number | string | Date,
) => Promise<void>;
export function utimesSync(
path: string | URL,
atime: number | string | Date,
mtime: number | string | Date,
) {
path = path instanceof URL ? fromFileUrl(path) : path;
atime = getValidTime(atime, "atime");
mtime = getValidTime(mtime, "mtime");
Deno.utimeSync(path, atime, mtime);
}