1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
A modern runtime for JavaScript and TypeScript. https://deno.com/
Find a file
Nathan Whitaker 8282c38fe0
fix(cli): increase size of blocking task threadpool on windows (#26465)
Fixes #26179.

The original error reported in that issue is fixed on canary, but in
local testing on my windows machine, `next build` would just hang
forever.

After some digging, what happens is that at some point in next build,
readFile promises (from `fs/promises` ) just never resolve, and so next
hangs.

It turns out the issue is saturating tokio's blocking task thread pool.
We previously limited the number of blocking threads to 32, and at some
point those threads are all in use and there's no thread available for
the file reads.

What's taking up all of those threads? The answer turns out to be
`tokio::process`. On windows, child process stdio uses the blocking
threadpool: https://github.com/tokio-rs/tokio/pull/4824. When you poll
the child's stdio on windows, it spawns a blocking task per poll, and
calls `std::io::Read::read` in the blocking context. That call can block
until data is available.
Putting it all together, what happens is that Next.js spawns `2 * the
number of CPU cores` deno child subprocesses to do work. We implement
`child_process` with `tokio::process`. When the child processes' stdio
get polled, blocking tasks get spawned, and those blocking tasks might
block until data is available. So if you have 16 cores (as I do), there
are going to be potentially >32 blocking task threadpool threads taken
just by the child processes. That leaves no room for other tasks to make
progress

---

To fix this, for now, increase the size of the blocking threadpool on
windows. 4 * the number of CPU cores should be enough to leave room for
other tasks to make progress.

Longer term, this can be fixed more properly when we handroll our own
subprocess code (needed for detached processes and additional pipes on
windows).
2024-10-22 12:52:18 -07:00
.cargo feat: bring back WebGPU (#20812) 2023-12-09 01:19:16 +01:00
.devcontainer chore: remove protoc dep from CI (#26050) 2024-10-07 15:11:31 +00:00
.github chore(ci): use setup-deno@v2 (#26474) 2024-10-22 20:54:27 +05:30
bench_util chore: forward v2.0.2 release commit to main (#26376) 2024-10-18 03:12:49 +02:00
cli fix(fmt): upgrade formatters (#26469) 2024-10-22 12:15:59 +02:00
ext fix(ext/console): ignore casing for named colors in css parsing (#26466) 2024-10-22 10:57:58 +02:00
resolvers chore: forward v2.0.2 release commit to main (#26376) 2024-10-18 03:12:49 +02:00
runtime fix(cli): increase size of blocking task threadpool on windows (#26465) 2024-10-22 12:52:18 -07:00
tests fix(ext/console): ignore casing for named colors in css parsing (#26466) 2024-10-22 10:57:58 +02:00
tools chore: update release doc template (#26406) 2024-10-19 09:12:19 +05:30
.dlint.json chore: enable no-console dlint rule (#25113) 2024-08-20 15:14:37 -04:00
.dprint.json fix(install): better json editing (#26450) 2024-10-21 14:17:08 -04:00
.editorconfig chore(tests): Remove vestiges of cli/tests folder (#22712) 2024-03-05 13:49:21 -07:00
.gitattributes chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
.gitignore chore: move tools/wpt to tests/wpt/runner (#22545) 2024-03-05 00:41:16 +00:00
.gitmodules chore: make remaining submodules shallow (#23441) 2024-04-18 19:45:09 +00:00
.rustfmt.toml chore: update copyright year to 2023 (#17247) 2023-01-02 21:00:42 +00:00
Cargo.lock fix(fmt): upgrade formatters (#26469) 2024-10-22 12:15:59 +02:00
Cargo.toml fix: unpin tokio version (#26457) 2024-10-22 09:58:31 -07:00
import_map.json chore: update std submodule (#25595) 2024-09-12 22:32:09 +10:00
LICENSE.md chore: update LICENSE.md to 2024 (#21833) 2024-01-06 19:14:38 -05:00
README.md chore: update references to deno_std to use JSR (#23239) 2024-04-10 17:26:35 -04:00
Releases.md chore: forward v2.0.2 release commit to main (#26376) 2024-10-18 03:12:49 +02:00
rust-toolchain.toml chore: upgrade to rust 1.81.0 (#26261) 2024-10-15 21:40:07 +05:30

Deno

Twitter badge Discord badge YouTube badge

the deno mascot dinosaur standing in the rain

Deno (/ˈdiːnoʊ/, pronounced dee-no) is a JavaScript, TypeScript, and WebAssembly runtime with secure defaults and a great developer experience. It's built on V8, Rust, and Tokio.

Learn more about the Deno runtime in the documentation.

Installation

Install the Deno runtime on your system using one of the commands below. Note that there are a number of ways to install Deno - a comprehensive list of installation options can be found here.

Shell (Mac, Linux):

curl -fsSL https://deno.land/install.sh | sh

PowerShell (Windows):

irm https://deno.land/install.ps1 | iex

Homebrew (Mac):

brew install deno

Chocolatey (Windows):

choco install deno

Build and install from source

Complete instructions for building Deno from source can be found in the manual here.

Your first Deno program

Deno can be used for many different applications, but is most commonly used to build web servers. Create a file called server.ts and include the following TypeScript code:

Deno.serve((_req: Request) => {
  return new Response("Hello, world!");
});

Run your server with the following command:

deno run --allow-net server.ts

This should start a local web server on http://localhost:8000.

Learn more about writing and running Deno programs in the docs.

Additional resources

Contributing

We appreciate your help! To contribute, please read our contributing instructions.