mirror of
https://github.com/denoland/deno.git
synced 2024-11-22 15:06:54 -05:00
1848c7e361
RUSTFLAGS take precedence over `target.<triple>.rustflags`. Therefore, setting the env var globally in CI would always override whatever linter rules are allowed or denied in .cargo/config.toml. With this change, we ensure that problems are detected both in CI and locally, using either cargo clippy or lint.js.
146 lines
3.5 KiB
JavaScript
Executable file
146 lines
3.5 KiB
JavaScript
Executable file
#!/usr/bin/env -S deno run --unstable --allow-write --allow-read --allow-run
|
|
// Copyright 2018-2022 the Deno authors. All rights reserved. MIT license.
|
|
import {
|
|
buildMode,
|
|
getPrebuiltToolPath,
|
|
getSources,
|
|
join,
|
|
ROOT_PATH,
|
|
} from "./util.js";
|
|
|
|
async function dlint() {
|
|
const configFile = join(ROOT_PATH, ".dlint.json");
|
|
const execPath = getPrebuiltToolPath("dlint");
|
|
console.log("dlint");
|
|
|
|
const sourceFiles = await getSources(ROOT_PATH, [
|
|
"*.js",
|
|
"*.ts",
|
|
":!:.github/mtime_cache/action.js",
|
|
":!:cli/tests/testdata/swc_syntax_error.ts",
|
|
":!:cli/tests/testdata/038_checkjs.js",
|
|
":!:cli/tests/testdata/error_008_checkjs.js",
|
|
":!:cli/bench/http/node*.js",
|
|
":!:cli/bench/testdata/npm/*",
|
|
":!:cli/bench/testdata/express-router.js",
|
|
":!:cli/bench/testdata/react-dom.js",
|
|
":!:cli/compilers/wasm_wrap.js",
|
|
":!:cli/dts/**",
|
|
":!:cli/tests/testdata/encoding/**",
|
|
":!:cli/tests/testdata/error_syntax.js",
|
|
":!:cli/tests/testdata/fmt/**",
|
|
":!:cli/tests/testdata/lint/**",
|
|
":!:cli/tests/testdata/tsc/**",
|
|
":!:cli/tsc/*typescript.js",
|
|
":!:cli/tsc/compiler.d.ts",
|
|
":!:test_util/wpt/**",
|
|
]);
|
|
|
|
if (!sourceFiles.length) {
|
|
return;
|
|
}
|
|
|
|
const chunks = splitToChunks(sourceFiles, `${execPath} run`.length);
|
|
for (const chunk of chunks) {
|
|
const { success } = await Deno.spawn(execPath, {
|
|
args: ["run", "--config=" + configFile, ...chunk],
|
|
stdout: "inherit",
|
|
stderr: "inherit",
|
|
});
|
|
if (!success) {
|
|
throw new Error("dlint failed");
|
|
}
|
|
}
|
|
}
|
|
|
|
// `prefer-primordials` has to apply only to files related to bootstrapping,
|
|
// which is different from other lint rules. This is why this dedicated function
|
|
// is needed.
|
|
async function dlintPreferPrimordials() {
|
|
const execPath = getPrebuiltToolPath("dlint");
|
|
console.log("prefer-primordials");
|
|
|
|
const sourceFiles = await getSources(ROOT_PATH, [
|
|
"runtime/**/*.js",
|
|
"ext/**/*.js",
|
|
"core/**/*.js",
|
|
":!:core/examples/**",
|
|
]);
|
|
|
|
if (!sourceFiles.length) {
|
|
return;
|
|
}
|
|
|
|
const chunks = splitToChunks(sourceFiles, `${execPath} run`.length);
|
|
for (const chunk of chunks) {
|
|
const { success } = await Deno.spawn(execPath, {
|
|
args: ["run", "--rule", "prefer-primordials", ...chunk],
|
|
stdout: "inherit",
|
|
stderr: "inherit",
|
|
});
|
|
if (!success) {
|
|
throw new Error("prefer-primordials failed");
|
|
}
|
|
}
|
|
}
|
|
|
|
function splitToChunks(paths, initCmdLen) {
|
|
let cmdLen = initCmdLen;
|
|
const MAX_COMMAND_LEN = 30000;
|
|
const chunks = [[]];
|
|
for (const p of paths) {
|
|
if (cmdLen + p.length > MAX_COMMAND_LEN) {
|
|
chunks.push([p]);
|
|
cmdLen = initCmdLen;
|
|
} else {
|
|
chunks[chunks.length - 1].push(p);
|
|
cmdLen += p.length;
|
|
}
|
|
}
|
|
return chunks;
|
|
}
|
|
|
|
async function clippy() {
|
|
console.log("clippy");
|
|
|
|
const currentBuildMode = buildMode();
|
|
const cmd = ["clippy", "--all-targets", "--locked"];
|
|
|
|
if (currentBuildMode != "debug") {
|
|
cmd.push("--release");
|
|
}
|
|
|
|
const { success } = await Deno.spawn("cargo", {
|
|
args: [...cmd, "--", "-D", "warnings"],
|
|
stdout: "inherit",
|
|
stderr: "inherit",
|
|
});
|
|
if (!success) {
|
|
throw new Error("clippy failed");
|
|
}
|
|
}
|
|
|
|
async function main() {
|
|
await Deno.chdir(ROOT_PATH);
|
|
|
|
let didLint = false;
|
|
|
|
if (Deno.args.includes("--js")) {
|
|
await dlint();
|
|
await dlintPreferPrimordials();
|
|
didLint = true;
|
|
}
|
|
|
|
if (Deno.args.includes("--rs")) {
|
|
await clippy();
|
|
didLint = true;
|
|
}
|
|
|
|
if (!didLint) {
|
|
await dlint();
|
|
await dlintPreferPrimordials();
|
|
await clippy();
|
|
}
|
|
}
|
|
|
|
await main();
|