mirror of
https://github.com/denoland/deno.git
synced 2024-12-25 08:39:09 -05:00
e511022c74
Code run within Deno-mode and Node-mode should have access to a slightly different set of globals. Previously this was done through a compile time code-transform for Node-mode, but this is not ideal and has many edge cases, for example Node's globalThis having a different identity than Deno's globalThis. This commit makes the `globalThis` of the entire runtime a semi-proxy. This proxy returns a different set of globals depending on the caller's mode. This is not a full proxy, because it is shadowed by "real" properties on globalThis. This is done to avoid the overhead of a full proxy for all globalThis operations. The globals between Deno-mode and Node-mode are now properly segregated. This means that code running in Deno-mode will not have access to Node's globals, and vice versa. Deleting a managed global in Deno-mode will NOT delete the corresponding global in Node-mode, and vice versa. --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com> Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
50 lines
1.9 KiB
TypeScript
50 lines
1.9 KiB
TypeScript
/// <reference types="npm:@types/node" />
|
|
|
|
import * as globals from "npm:@denotest/globals";
|
|
console.log(globals.global === globals.globalThis);
|
|
// @ts-expect-error even though these are the same object, they have different types
|
|
console.log(globals.globalThis === globalThis);
|
|
console.log(globals.process.execArgv);
|
|
|
|
type AssertTrue<T extends true> = never;
|
|
type _TestNoProcessGlobal = AssertTrue<
|
|
typeof globalThis extends { process: any } ? false : true
|
|
>;
|
|
type _TestHasNodeJsGlobal = NodeJS.Architecture;
|
|
|
|
const controller = new AbortController();
|
|
controller.abort("reason"); // in the NodeJS declaration it doesn't have a reason
|
|
|
|
// Some globals are not the same between Node and Deno.
|
|
// @ts-expect-error incompatible types between Node and Deno
|
|
console.log(globalThis.setTimeout === globals.getSetTimeout());
|
|
|
|
// Super edge case where some Node code deletes a global where the
|
|
// Node code has its own global and the Deno code has the same global,
|
|
// but it's different. Basically if some Node code deletes
|
|
// one of these globals then we don't want it to suddenly inherit
|
|
// the Deno global (or touch the Deno global at all).
|
|
console.log(typeof globalThis.setTimeout);
|
|
console.log(typeof globals.getSetTimeout());
|
|
globals.deleteSetTimeout();
|
|
console.log(typeof globalThis.setTimeout);
|
|
console.log(typeof globals.getSetTimeout());
|
|
|
|
// In Deno, the process global is not defined, but in Node it is.
|
|
console.log("process" in globalThis);
|
|
console.log(
|
|
Object.getOwnPropertyDescriptor(globalThis, "process") !== undefined,
|
|
);
|
|
globals.checkProcessGlobal();
|
|
|
|
// In Deno, the window global is defined, but in Node it is not.
|
|
console.log("window" in globalThis);
|
|
console.log(
|
|
Object.getOwnPropertyDescriptor(globalThis, "window") !== undefined,
|
|
);
|
|
globals.checkWindowGlobal();
|
|
|
|
// "Non-managed" globals are shared between Node and Deno.
|
|
(globalThis as any).foo = "bar";
|
|
console.log((globalThis as any).foo);
|
|
console.log(globals.getFoo());
|