mirror of
https://github.com/denoland/deno.git
synced 2024-11-21 15:04:11 -05:00
2164f6b1eb
Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params).
Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple:
```
opSync("op_foo", param1, param2);
// -> turns to
ops.op_foo(param1, param2);
```
This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path.
Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader.
86 lines
2.1 KiB
JavaScript
86 lines
2.1 KiB
JavaScript
// Copyright 2018-2022 the Deno authors. All rights reserved. MIT license.
|
|
"use strict";
|
|
|
|
((window) => {
|
|
const core = window.Deno.core;
|
|
const ops = core.ops;
|
|
const {
|
|
Set,
|
|
SymbolFor,
|
|
TypeError,
|
|
} = window.__bootstrap.primordials;
|
|
|
|
function bindSignal(signo) {
|
|
return ops.op_signal_bind(signo);
|
|
}
|
|
|
|
function pollSignal(rid) {
|
|
const promise = core.opAsync("op_signal_poll", rid);
|
|
core.unrefOp(promise[SymbolFor("Deno.core.internalPromiseId")]);
|
|
return promise;
|
|
}
|
|
|
|
function unbindSignal(rid) {
|
|
ops.op_signal_unbind(rid);
|
|
}
|
|
|
|
// Stores signal listeners and resource data. This has type of
|
|
// `Record<string, { rid: number | undefined, listeners: Set<() => void> }`
|
|
const signalData = {};
|
|
|
|
/** Gets the signal handlers and resource data of the given signal */
|
|
function getSignalData(signo) {
|
|
return signalData[signo] ??
|
|
(signalData[signo] = { rid: undefined, listeners: new Set() });
|
|
}
|
|
|
|
function checkSignalListenerType(listener) {
|
|
if (typeof listener !== "function") {
|
|
throw new TypeError(
|
|
`Signal listener must be a function. "${typeof listener}" is given.`,
|
|
);
|
|
}
|
|
}
|
|
|
|
function addSignalListener(signo, listener) {
|
|
checkSignalListenerType(listener);
|
|
|
|
const sigData = getSignalData(signo);
|
|
sigData.listeners.add(listener);
|
|
|
|
if (!sigData.rid) {
|
|
// If signal resource doesn't exist, create it.
|
|
// The program starts listening to the signal
|
|
sigData.rid = bindSignal(signo);
|
|
loop(sigData);
|
|
}
|
|
}
|
|
|
|
function removeSignalListener(signo, listener) {
|
|
checkSignalListenerType(listener);
|
|
|
|
const sigData = getSignalData(signo);
|
|
sigData.listeners.delete(listener);
|
|
|
|
if (sigData.listeners.size === 0 && sigData.rid) {
|
|
unbindSignal(sigData.rid);
|
|
sigData.rid = undefined;
|
|
}
|
|
}
|
|
|
|
async function loop(sigData) {
|
|
while (sigData.rid) {
|
|
if (await pollSignal(sigData.rid)) {
|
|
return;
|
|
}
|
|
for (const listener of sigData.listeners) {
|
|
listener();
|
|
}
|
|
}
|
|
}
|
|
|
|
window.__bootstrap.signals = {
|
|
addSignalListener,
|
|
removeSignalListener,
|
|
};
|
|
})(this);
|