mirror of
https://github.com/denoland/deno.git
synced 2024-12-25 08:39:09 -05:00
b2cd254c35
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when
using `Object.prototype.isPrototypeOf` to check built-in types.
```js
import vm from "node:vm";
const err = new Error();
const crossErr = vm.runInNewContext(`new Error()`);
console.assert( !(crossErr instanceof Error) );
console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) );
```
This PR changes to check using internal slots solves them.
---
current:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error {}
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
Date {}
```
this PR:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error: message
at <anonymous>:1:1
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
2018-12-10T02:26:59.002Z
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
35 lines
890 B
Rust
35 lines
890 B
Rust
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
use deno_core::op2;
|
|
use deno_core::v8;
|
|
use std::path::PathBuf;
|
|
|
|
deno_core::extension!(
|
|
deno_console,
|
|
ops = [op_preview_entries],
|
|
esm = ["01_console.js"],
|
|
);
|
|
|
|
pub fn get_declaration() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("lib.deno_console.d.ts")
|
|
}
|
|
|
|
#[op2]
|
|
pub fn op_preview_entries<'s>(
|
|
scope: &mut v8::HandleScope<'s>,
|
|
object: &v8::Object,
|
|
slow_path: bool,
|
|
) -> v8::Local<'s, v8::Value> {
|
|
let (entries, is_key_value) = object.preview_entries(scope);
|
|
match entries {
|
|
None => v8::undefined(scope).into(),
|
|
Some(entries) => {
|
|
if !slow_path {
|
|
return entries.into();
|
|
}
|
|
|
|
let ret: [v8::Local<v8::Value>; 2] =
|
|
[entries.into(), v8::Boolean::new(scope, is_key_value).into()];
|
|
v8::Array::new_with_elements(scope, &ret).into()
|
|
}
|
|
}
|
|
}
|