mirror of
https://github.com/denoland/deno.git
synced 2024-11-26 16:09:27 -05:00
cd59fc53a5
Fixes https://github.com/denoland/deno/issues/24756. Fixes https://github.com/denoland/deno/issues/24796. This also gets vitest working when using [`--pool=forks`](https://vitest.dev/guide/improving-performance#pool) (which is the default as of vitest 2.0). Ref https://github.com/denoland/deno/issues/23882. --- This PR resolves a handful of issues with child_process IPC. In particular: - We didn't support sending typed array views over IPC - Opening an IPC channel resulted in the event loop never exiting - Sending a `null` over IPC would terminate the channel - There was some UB in the read implementation (transmuting an `&[u8]` to `&mut [u8]`) - The `send` method wasn't returning anything, so there was no way to signal backpressure (this also resulted in the benchmark `child_process_ipc.mjs` being misleading, as it tried to respect backpressure. That gave node much worse results at larger message sizes, and gave us much worse results at smaller message sizes). - We weren't setting up the `channel` property on the `process` global (or on the `ChildProcess` object), and also didn't have a way to ref/unref the channel - Calling `kill` multiple times (or disconnecting the channel, then calling kill) would throw an error - Node couldn't spawn a deno subprocess and communicate with it over IPC |
||
|---|---|---|
| .. | ||
| console | ||
| crypto | ||
| dns | ||
| fs | ||
| process | ||
| readline | ||
| streams | ||
| test | ||
| util | ||
| assert.mjs | ||
| async_hooks.ts | ||
| blocklist.mjs | ||
| buffer.d.ts | ||
| buffer.mjs | ||
| child_process.ts | ||
| cli_table.ts | ||
| constants.ts | ||
| dgram.ts | ||
| dtrace.ts | ||
| error_codes.ts | ||
| errors.ts | ||
| event_target.mjs | ||
| fixed_queue.ts | ||
| hide_stack_frames.ts | ||
| http.ts | ||
| idna.ts | ||
| net.ts | ||
| normalize_encoding.mjs | ||
| options.ts | ||
| primordials.mjs | ||
| querystring.ts | ||
| stream_base_commons.ts | ||
| timers.mjs | ||
| url.ts | ||
| util.mjs | ||
| validators.mjs | ||