1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-21 23:04:45 -05:00
denoland-deno/tests/node_compat/test
Nathan Whitaker a77b2987bc
fix(ext/node): Match punycode module behavior to node (#22847)
Fixes #19214.

We were using the `idna` crate to implement our polyfill for
`punycode.toASCII` and `punycode.toUnicode`. The `idna` crate is
correct, and adheres to the IDNA2003/2008 spec, but it turns out
`node`'s implementations don't really follow any spec! Instead, node
splits the domain by `'.'` and punycode encodes/decodes each part. This
means that node's implementations will happily work on codepoints that
are disallowed by the IDNA specs, causing the error in #19214.

While fixing this, I went ahead and matched the node behavior on all of
the punycode functions and enabled node's punycode test in our
`node_compat` suite.
2024-03-11 15:49:43 -07:00
..
common chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
fixtures chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
internet chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
parallel fix(ext/node): Match punycode module behavior to node (#22847) 2024-03-11 15:49:43 -07:00
pseudo-tty chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
pummel chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00
sequential chore: move cli/tests/ -> tests/ (#22369) 2024-02-10 20:22:13 +00:00