mirror of
https://github.com/denoland/deno.git
synced 2024-11-29 16:30:56 -05:00
ab60d9e6a3
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when
using `Object.prototype.isPrototypeOf` to check built-in types.
```js
import vm from "node:vm";
const err = new Error();
const crossErr = vm.runInNewContext(`new Error()`);
console.assert( !(crossErr instanceof Error) );
console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) );
```
This PR changes to check using internal slots solves them.
---
current:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error {}
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
Date {}
```
this PR:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error: message
at <anonymous>:1:1
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
2018-12-10T02:26:59.002Z
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
||
|---|---|---|
| .. | ||
| autobahn | ||
| 00_ops.js | ||
| 01_websocket.js | ||
| 02_websocketstream.js | ||
| Cargo.toml | ||
| lib.deno_websocket.d.ts | ||
| lib.rs | ||
| README.md | ||
| stream.rs | ||
deno_websocket
This op crate implements the websocket functions of Deno.
Spec: https://html.spec.whatwg.org/multipage/web-sockets.html