mirror of
https://github.com/denoland/deno.git
synced 2024-12-22 15:24:46 -05:00
d8293cd8bc
The following code:
```rust
use deno_core::op;
#[op]
fn ops_serde_v8(value: serde_v8::Value) {
//
}
fn main() {
//
}
```
...with the following `Cargo.toml`:
```toml
[package]
name = "playground"
version = "0.1.0"
edition = "2021"
[dependencies]
deno_core = "0.191.0"
serde_v8 = "0.102.0"
```
...will not compile with the error:
```
error[E0433]: failed to resolve: use of undeclared crate or module `v8`
--> src/main.rs:3:1
|
3 | #[op]
| ^^^^^ use of undeclared crate or module `v8`
|
= note: this error originates in the attribute macro `op` (in Nightly builds, run with -Z macro-backtrace for more info)
```
This PR is fixing the above issue by properly quoting
`deno_core::v8::Value` instead of `v8::Value`.
|
||
|---|---|---|
| .. | ||
| op2 | ||
| optimizer_tests | ||
| tests/compile_fail | ||
| attrs.rs | ||
| Cargo.toml | ||
| deno.rs | ||
| fast_call.rs | ||
| lib.rs | ||
| optimizer.rs | ||
| README.md | ||
deno_ops
proc_macro for generating highly optimized V8 functions from Deno ops.
// Declare an op.
#[op(fast)]
pub fn op_add(_: &mut OpState, a: i32, b: i32) -> i32 {
a + b
}
// Register with an extension.
Extension::builder()
.ops(vec![op_add::decl()])
.build();
Performance
The macro can optimize away code, short circuit fast paths and generate a Fast API impl.
Cases where code is optimized away:
-> ()skips serde_v8 andrv.setcalls.-> Result<(), E>skips serde_v8 andrv.setcalls forOk()branch.-> ResourceIdor-> [int]types will use specialized method likev8::ReturnValue::set_uint32. A fast path for SMI.-> Result<ResourceId, E>or-> Result<[int], E>types will be optimized like above for theOk()branch.
Fast calls
The macro will infer and try to auto generate V8 fast API call trait impl for
sync ops with:
- arguments: integers, bool,
&mut OpState,&[u8],&mut [u8],&[u32],&mut [u32] - return_type: integers, bool
The #[op(fast)] attribute should be used to enforce fast call generation at
compile time.
Trait gen for async ops & a ZeroCopyBuf equivalent type is planned and will be
added soon.
Wasm calls
The #[op(wasm)] attribute should be used for calls expected to be called from
Wasm. This enables the fast call generation and allows seamless WasmMemory
integration for generic and fast calls.
#[op(wasm)]
pub fn op_args_get(
offset: i32,
buffer_offset: i32,
memory: Option<&[u8]>, // Must be last parameter. Some(..) when entered from Wasm.
) {
// ...
}