1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
denoland-deno/ops
Matt Mastracci fbb6932934
refactor(ops): op2 support for generics (#19636)
Implementation of generics for `#[op2]`, along with some refactoring to
improve the ergonomics of ops with generics parameters:

- The ops have generics on the struct rather than the associated
methods, which allows us to trait-ify ops (impossible when they are on
the methods)
- The decl() method can become a trait-associated const field which
unlocks future optimizations

Callers of ops need to switch from:
`op_net_connect_tcp::call::<TestPermission>(conn_state, ip_addr)` to
`op_net_connect_tcp::<TestPermission>::call(conn_state, ip_addr)`.
2023-06-29 10:23:14 -06:00
..
op2 refactor(ops): op2 support for generics (#19636) 2023-06-29 10:23:14 -06:00
optimizer_tests refactor(ops): op2 support for generics (#19636) 2023-06-29 10:23:14 -06:00
tests/compile_fail fix(ops): disallow memory slices as inputs to async ops (#16738) 2023-01-15 07:40:01 +00:00
attrs.rs feat(ops): relational ops (#18023) 2023-03-05 13:30:22 +05:30
Cargo.toml refactor(ops): Adding op2 macro and implementing in a couple of places (#19534) 2023-06-24 13:54:10 +02:00
deno.rs chore: fix typos (#19572) 2023-06-26 09:10:27 -04:00
fast_call.rs refactor(ops): op2 support for generics (#19636) 2023-06-29 10:23:14 -06:00
lib.rs refactor(ops): op2 support for generics (#19636) 2023-06-29 10:23:14 -06:00
optimizer.rs chore: fix typos (#19572) 2023-06-26 09:10:27 -04:00
README.md feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30

deno_ops

proc_macro for generating highly optimized V8 functions from Deno ops.

// Declare an op.
#[op(fast)]
pub fn op_add(_: &mut OpState, a: i32, b: i32) -> i32 {
  a + b
}

// Register with an extension.
Extension::builder()
  .ops(vec![op_add::decl()])
  .build();

Performance

The macro can optimize away code, short circuit fast paths and generate a Fast API impl.

Cases where code is optimized away:

  • -> () skips serde_v8 and rv.set calls.
  • -> Result<(), E> skips serde_v8 and rv.set calls for Ok() branch.
  • -> ResourceId or -> [int] types will use specialized method like v8::ReturnValue::set_uint32. A fast path for SMI.
  • -> Result<ResourceId, E> or -> Result<[int], E> types will be optimized like above for the Ok() branch.

Fast calls

The macro will infer and try to auto generate V8 fast API call trait impl for sync ops with:

  • arguments: integers, bool, &mut OpState, &[u8], &mut [u8], &[u32], &mut [u32]
  • return_type: integers, bool

The #[op(fast)] attribute should be used to enforce fast call generation at compile time.

Trait gen for async ops & a ZeroCopyBuf equivalent type is planned and will be added soon.

Wasm calls

The #[op(wasm)] attribute should be used for calls expected to be called from Wasm. This enables the fast call generation and allows seamless WasmMemory integration for generic and fast calls.

#[op(wasm)]
pub fn op_args_get(
  offset: i32,
  buffer_offset: i32,
  memory: Option<&[u8]>, // Must be last parameter. Some(..) when entered from Wasm.
) {
  // ...
}