mirror of
https://github.com/denoland/deno.git
synced 2024-12-22 15:24:46 -05:00
b2cd254c35
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when
using `Object.prototype.isPrototypeOf` to check built-in types.
```js
import vm from "node:vm";
const err = new Error();
const crossErr = vm.runInNewContext(`new Error()`);
console.assert( !(crossErr instanceof Error) );
console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) );
```
This PR changes to check using internal slots solves them.
---
current:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error {}
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
Date {}
```
this PR:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error: message
at <anonymous>:1:1
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
2018-12-10T02:26:59.002Z
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
||
|---|---|---|
| .. | ||
| 20_headers.js | ||
| 21_formdata.js | ||
| 22_body.js | ||
| 22_http_client.js | ||
| 23_request.js | ||
| 23_response.js | ||
| 26_fetch.js | ||
| 27_eventsource.js | ||
| Cargo.toml | ||
| fs_fetch_handler.rs | ||
| internal.d.ts | ||
| lib.deno_fetch.d.ts | ||
| lib.rs | ||
| README.md | ||