mirror of
https://github.com/denoland/deno.git
synced 2024-12-11 18:17:48 -05:00
ce75e31625
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
48 lines
1.5 KiB
JavaScript
48 lines
1.5 KiB
JavaScript
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
// Copyright Joyent and Node contributors. All rights reserved. MIT license.
|
|
// deno-lint-ignore-file
|
|
|
|
import { AbortError, ERR_INVALID_ARG_TYPE } from "internal:deno_node/internal/errors.ts";
|
|
import eos from "internal:deno_node/internal/streams/end-of-stream.mjs";
|
|
|
|
// This method is inlined here for readable-stream
|
|
// It also does not allow for signal to not exist on the stream
|
|
// https://github.com/nodejs/node/pull/36061#discussion_r533718029
|
|
const validateAbortSignal = (signal, name) => {
|
|
if (
|
|
typeof signal !== "object" ||
|
|
!("aborted" in signal)
|
|
) {
|
|
throw new ERR_INVALID_ARG_TYPE(name, "AbortSignal", signal);
|
|
}
|
|
};
|
|
|
|
function isStream(obj) {
|
|
return !!(obj && typeof obj.pipe === "function");
|
|
}
|
|
|
|
function addAbortSignal(signal, stream) {
|
|
validateAbortSignal(signal, "signal");
|
|
if (!isStream(stream)) {
|
|
throw new ERR_INVALID_ARG_TYPE("stream", "stream.Stream", stream);
|
|
}
|
|
return addAbortSignalNoValidate(signal, stream);
|
|
}
|
|
function addAbortSignalNoValidate(signal, stream) {
|
|
if (typeof signal !== "object" || !("aborted" in signal)) {
|
|
return stream;
|
|
}
|
|
const onAbort = () => {
|
|
stream.destroy(new AbortError());
|
|
};
|
|
if (signal.aborted) {
|
|
onAbort();
|
|
} else {
|
|
signal.addEventListener("abort", onAbort);
|
|
eos(stream, () => signal.removeEventListener("abort", onAbort));
|
|
}
|
|
return stream;
|
|
}
|
|
|
|
export default { addAbortSignal, addAbortSignalNoValidate };
|
|
export { addAbortSignal, addAbortSignalNoValidate };
|