mirror of
https://github.com/denoland/deno.git
synced 2024-11-29 16:30:56 -05:00
702284dc22
This commit changes "eager ops" to directly return a response value instead of calling "opresponse" callback in JavaScript. This saves one boundary crossing and has a fantastic impact on the "async_ops.js" benchmark: ``` v1.32.4 $ deno run cli/bench/async_ops.js time 329 ms rate 3039513 time 322 ms rate 3105590 time 307 ms rate 3257328 time 301 ms rate 3322259 time 303 ms rate 3300330 time 306 ms rate 3267973 time 300 ms rate 3333333 time 301 ms rate 3322259 time 301 ms rate 3322259 time 301 ms rate 3322259 time 302 ms rate 3311258 time 301 ms rate 3322259 time 302 ms rate 3311258 time 302 ms rate 3311258 time 303 ms rate 3300330 ``` ``` this branch $ ./target/release/deno run -A cli/bench/async_ops.js time 257 ms rate 3891050 time 248 ms rate 4032258 time 251 ms rate 3984063 time 246 ms rate 4065040 time 238 ms rate 4201680 time 227 ms rate 4405286 time 228 ms rate 4385964 time 229 ms rate 4366812 time 228 ms rate 4385964 time 226 ms rate 4424778 time 226 ms rate 4424778 time 227 ms rate 4405286 time 228 ms rate 4385964 time 227 ms rate 4405286 time 228 ms rate 4385964 time 227 ms rate 4405286 time 229 ms rate 4366812 time 228 ms rate 4385964 ``` Prerequisite for https://github.com/denoland/deno/pull/18652
107 lines
3.6 KiB
Text
107 lines
3.6 KiB
Text
#[allow(non_camel_case_types)]
|
|
///Auto-generated by `deno_ops`, i.e: `#[op]`
|
|
///
|
|
///Use `send_stdin::decl()` to get an op-declaration
|
|
///you can include in a `deno_core::Extension`.
|
|
pub struct send_stdin;
|
|
#[doc(hidden)]
|
|
impl send_stdin {
|
|
pub const fn name() -> &'static str {
|
|
stringify!(send_stdin)
|
|
}
|
|
#[allow(clippy::not_unsafe_ptr_arg_deref)]
|
|
pub extern "C" fn v8_fn_ptr<'scope>(
|
|
info: *const deno_core::v8::FunctionCallbackInfo,
|
|
) {
|
|
let info = unsafe { &*info };
|
|
let scope = &mut unsafe { deno_core::v8::CallbackScope::new(info) };
|
|
let args = deno_core::v8::FunctionCallbackArguments::from_function_callback_info(
|
|
info,
|
|
);
|
|
let rv = deno_core::v8::ReturnValue::from_function_callback_info(info);
|
|
Self::v8_func(scope, args, rv);
|
|
}
|
|
pub const fn decl<'scope>() -> deno_core::OpDecl {
|
|
deno_core::OpDecl {
|
|
name: Self::name(),
|
|
v8_fn_ptr: Self::v8_fn_ptr as _,
|
|
enabled: true,
|
|
fast_fn: None,
|
|
is_async: true,
|
|
is_unstable: false,
|
|
is_v8: false,
|
|
force_registration: false,
|
|
}
|
|
}
|
|
#[inline]
|
|
#[allow(clippy::too_many_arguments)]
|
|
async fn call(state: &mut OpState, v: i32) -> Result<(), anyhow::Error> {
|
|
Ok(())
|
|
}
|
|
pub fn v8_func<'scope>(
|
|
scope: &mut deno_core::v8::HandleScope<'scope>,
|
|
args: deno_core::v8::FunctionCallbackArguments,
|
|
mut rv: deno_core::v8::ReturnValue,
|
|
) {
|
|
use deno_core::futures::FutureExt;
|
|
let ctx = unsafe {
|
|
&*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
|
|
as *const deno_core::_ops::OpCtx)
|
|
};
|
|
let op_id = ctx.id;
|
|
let realm_idx = ctx.realm_idx;
|
|
let promise_id = args.get(0);
|
|
let promise_id = deno_core::v8::Local::<
|
|
deno_core::v8::Integer,
|
|
>::try_from(promise_id)
|
|
.map(|l| l.value() as deno_core::PromiseId)
|
|
.map_err(deno_core::anyhow::Error::from);
|
|
let promise_id: deno_core::PromiseId = match promise_id {
|
|
Ok(promise_id) => promise_id,
|
|
Err(err) => {
|
|
deno_core::_ops::throw_type_error(
|
|
scope,
|
|
format!("invalid promise id: {}", err),
|
|
);
|
|
return;
|
|
}
|
|
};
|
|
let arg_0 = args.get(1usize as i32);
|
|
let arg_0 = match deno_core::serde_v8::from_v8(scope, arg_0) {
|
|
Ok(v) => v,
|
|
Err(err) => {
|
|
let msg = format!(
|
|
"Error parsing args at position {}: {}", 1usize,
|
|
deno_core::anyhow::Error::from(err)
|
|
);
|
|
return deno_core::_ops::throw_type_error(scope, msg);
|
|
}
|
|
};
|
|
let get_class = {
|
|
let state = ::std::cell::RefCell::borrow(&ctx.state);
|
|
state.tracker.track_async(op_id);
|
|
state.get_error_class_fn
|
|
};
|
|
let maybe_response = deno_core::_ops::queue_async_op(
|
|
ctx,
|
|
scope,
|
|
false,
|
|
async move {
|
|
let result = Self::call(
|
|
compile_error!("mutable opstate is not supported in async ops"),
|
|
arg_0,
|
|
)
|
|
.await;
|
|
(
|
|
realm_idx,
|
|
promise_id,
|
|
op_id,
|
|
deno_core::_ops::to_op_result(get_class, result),
|
|
)
|
|
},
|
|
);
|
|
if let Some(response) = maybe_response {
|
|
rv.set(response);
|
|
}
|
|
}
|
|
}
|