mirror of
https://github.com/denoland/deno.git
synced 2024-11-24 15:19:26 -05:00
b2cd254c35
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when
using `Object.prototype.isPrototypeOf` to check built-in types.
```js
import vm from "node:vm";
const err = new Error();
const crossErr = vm.runInNewContext(`new Error()`);
console.assert( !(crossErr instanceof Error) );
console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) );
```
This PR changes to check using internal slots solves them.
---
current:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error {}
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
Date {}
```
this PR:
```
> import vm from "node:vm";
undefined
> vm.runInNewContext(`new Error("message")`)
Error: message
at <anonymous>:1:1
> vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)
2018-12-10T02:26:59.002Z
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
||
|---|---|---|
| .. | ||
| benchmarks | ||
| ops | ||
| polyfills | ||
| analyze.rs | ||
| build.rs | ||
| Cargo.toml | ||
| clippy.toml | ||
| errors.rs | ||
| global.rs | ||
| lib.rs | ||
| package_json.rs | ||
| path.rs | ||
| polyfill.rs | ||
| README.md | ||
| resolution.rs | ||
deno_node
require and other node related functionality for Deno.