denoland-deno/cli/tests/testdata/wasm_streaming_panic_test.js.out at c3f306d7782a30440435d4b3493a9f681bb31e09 - foster/denoland-deno - Foster's Laboratory

foster/denoland-deno

mirror of https://github.com/denoland/deno.git synced 2024-11-26 16:09:27 -05:00

Andreu Botella 12d28dffc6

fix(fetch): Fix uncaught rejection panic with WebAssembly.instantiateStreaming (#13925 )

When an exception is thrown during the processing of streaming WebAssembly,
`op_wasm_streaming_abort` is called. This op calls into V8, which synchronously
rejects the promise and calls into the promise rejection handler, if applicable.
But calling an op borrows the isolate's `JsRuntimeState` for the duration of the
op, which means it is borrowed when V8 calls into `promise_reject_callback`,
which tries to borrow it again, panicking.

This change changes `op_wasm_streaming_abort` from an op to a binding
(`Deno.core.abortWasmStreaming`). Although that binding must borrow the
`JsRuntimeState` in order to access the `WasmStreamingResource` stored in the
`OpTable`, it also takes ownership of that `WasmStreamingResource` instance,
which means it can drop any borrows of the `JsRuntimeState` before calling into
V8.

2022-03-22 11:33:29 +01:00

2 lines

119 B

Text

Raw Blame History

	`error: Uncaught (in promise) TypeError: Invalid WebAssembly content type.`
	`at deno:ext/fetch/26_fetch.js:[WILDCARD]`