mirror of
https://github.com/denoland/deno.git
synced 2024-12-12 02:27:46 -05:00
ce75e31625
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
108 lines
2.9 KiB
TypeScript
108 lines
2.9 KiB
TypeScript
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
import {
|
|
emitRecursiveRmdirWarning,
|
|
getValidatedPath,
|
|
validateRmdirOptions,
|
|
validateRmOptions,
|
|
validateRmOptionsSync,
|
|
} from "internal:deno_node/internal/fs/utils.mjs";
|
|
import { toNamespacedPath } from "internal:deno_node/path.ts";
|
|
import {
|
|
denoErrorToNodeError,
|
|
ERR_FS_RMDIR_ENOTDIR,
|
|
} from "internal:deno_node/internal/errors.ts";
|
|
import { Buffer } from "internal:deno_node/buffer.ts";
|
|
import { promisify } from "internal:deno_node/internal/util.mjs";
|
|
|
|
type rmdirOptions = {
|
|
maxRetries?: number;
|
|
recursive?: boolean;
|
|
retryDelay?: number;
|
|
};
|
|
|
|
type rmdirCallback = (err?: Error) => void;
|
|
|
|
export function rmdir(path: string | URL, callback: rmdirCallback): void;
|
|
export function rmdir(
|
|
path: string | URL,
|
|
options: rmdirOptions,
|
|
callback: rmdirCallback,
|
|
): void;
|
|
export function rmdir(
|
|
path: string | URL,
|
|
optionsOrCallback: rmdirOptions | rmdirCallback,
|
|
maybeCallback?: rmdirCallback,
|
|
) {
|
|
path = toNamespacedPath(getValidatedPath(path) as string);
|
|
|
|
const callback = typeof optionsOrCallback === "function"
|
|
? optionsOrCallback
|
|
: maybeCallback;
|
|
const options = typeof optionsOrCallback === "object"
|
|
? optionsOrCallback
|
|
: undefined;
|
|
|
|
if (!callback) throw new Error("No callback function supplied");
|
|
|
|
if (options?.recursive) {
|
|
emitRecursiveRmdirWarning();
|
|
validateRmOptions(
|
|
path,
|
|
{ ...options, force: false },
|
|
true,
|
|
(err: Error | null | false, options: rmdirOptions) => {
|
|
if (err === false) {
|
|
return callback(new ERR_FS_RMDIR_ENOTDIR(path.toString()));
|
|
}
|
|
if (err) {
|
|
return callback(err);
|
|
}
|
|
|
|
Deno.remove(path, { recursive: options?.recursive })
|
|
.then((_) => callback(), callback);
|
|
},
|
|
);
|
|
} else {
|
|
validateRmdirOptions(options);
|
|
Deno.remove(path, { recursive: options?.recursive })
|
|
.then((_) => callback(), (err: unknown) => {
|
|
callback(
|
|
err instanceof Error
|
|
? denoErrorToNodeError(err, { syscall: "rmdir" })
|
|
: err,
|
|
);
|
|
});
|
|
}
|
|
}
|
|
|
|
export const rmdirPromise = promisify(rmdir) as (
|
|
path: string | Buffer | URL,
|
|
options?: rmdirOptions,
|
|
) => Promise<void>;
|
|
|
|
export function rmdirSync(path: string | Buffer | URL, options?: rmdirOptions) {
|
|
path = getValidatedPath(path);
|
|
if (options?.recursive) {
|
|
emitRecursiveRmdirWarning();
|
|
const optionsOrFalse: rmdirOptions | false = validateRmOptionsSync(path, {
|
|
...options,
|
|
force: false,
|
|
}, true);
|
|
if (optionsOrFalse === false) {
|
|
throw new ERR_FS_RMDIR_ENOTDIR(path.toString());
|
|
}
|
|
options = optionsOrFalse;
|
|
} else {
|
|
validateRmdirOptions(options);
|
|
}
|
|
|
|
try {
|
|
Deno.removeSync(toNamespacedPath(path as string), {
|
|
recursive: options?.recursive,
|
|
});
|
|
} catch (err: unknown) {
|
|
throw (err instanceof Error
|
|
? denoErrorToNodeError(err, { syscall: "rmdir" })
|
|
: err);
|
|
}
|
|
}
|