1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
denoland-deno/ext/node
Nathan Whitaker ce7dc2be92
feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) (#24487)
Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.

With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.

Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).

When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.

Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry

---

TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes

---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
2024-07-10 03:06:08 +00:00
..
benchmarks fix: implement child_process IPC (#21490) 2023-12-13 11:14:16 +01:00
ops refactor: use concrete error types for node resolution (#24470) 2024-07-09 12:15:03 -04:00
polyfills feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) (#24487) 2024-07-10 03:06:08 +00:00
analyze.rs refactor: use concrete error types for node resolution (#24470) 2024-07-09 12:15:03 -04:00
build.rs chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00
Cargo.toml refactor: use concrete error types for node resolution (#24470) 2024-07-09 12:15:03 -04:00
clippy.toml refactor(ext/fs): deno_fs::FileSystem - conditional Send + Sync (#18993) 2023-05-08 11:02:02 -04:00
errors.rs refactor: use concrete error types for node resolution (#24470) 2024-07-09 12:15:03 -04:00
global.rs fix: do not return undefined for missing global properties (#24474) 2024-07-09 10:07:56 -07:00
lib.rs refactor: use concrete error types for node resolution (#24470) 2024-07-09 12:15:03 -04:00
package_json.rs refactor: move PackageJson to deno_config (#24348) 2024-06-26 21:24:10 +00:00
path.rs chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00
polyfill.rs fix(node): add missing readline/promises module (#24336) 2024-06-25 19:15:54 -04:00
README.md chore(ext/node): correct publishing for ext/node (#15461) 2022-08-11 17:25:41 -04:00
resolution.rs feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) (#24487) 2024-07-10 03:06:08 +00:00

deno_node

require and other node related functionality for Deno.