mirror of
https://github.com/denoland/deno.git
synced 2024-12-27 01:29:14 -05:00
9845361153
Partially supersedes #19016. This migrates `spawn` and `spawn_blocking` to `deno_core`, and removes the requirement for `spawn` tasks to be `Send` given our single-threaded executor. While we don't need to technically do anything w/`spawn_blocking`, this allows us to have a single `JoinHandle` type that works for both cases, and allows us to more easily experiment with alternative `spawn_blocking` implementations that do not require tokio (ie: rayon). Async ops (+~35%): Before: ``` time 1310 ms rate 763358 time 1267 ms rate 789265 time 1259 ms rate 794281 time 1266 ms rate 789889 ``` After: ``` time 956 ms rate 1046025 time 954 ms rate 1048218 time 924 ms rate 1082251 time 920 ms rate 1086956 ``` HTTP serve (+~4.4%): Before: ``` Running 10s test @ http://localhost:4500 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 68.78us 19.77us 1.43ms 86.84% Req/Sec 68.78k 5.00k 73.84k 91.58% 1381833 requests in 10.10s, 167.36MB read Requests/sec: 136823.29 Transfer/sec: 16.57MB ``` After: ``` Running 10s test @ http://localhost:4500 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 63.12us 17.43us 1.11ms 85.13% Req/Sec 71.82k 3.71k 77.02k 79.21% 1443195 requests in 10.10s, 174.79MB read Requests/sec: 142921.99 Transfer/sec: 17.31MB ``` Suggested-By: alice@ryhl.io Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
73 lines
1.9 KiB
Rust
73 lines
1.9 KiB
Rust
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
|
|
use deno_core::task::spawn;
|
|
use tokio::time::sleep;
|
|
use tokio::time::Duration;
|
|
|
|
/// Starts a task that will check for the existence of the
|
|
/// provided process id. Once that process no longer exists
|
|
/// it will terminate the current process.
|
|
pub fn start(parent_process_id: u32) {
|
|
spawn(async move {
|
|
loop {
|
|
sleep(Duration::from_secs(30)).await;
|
|
|
|
if !is_process_active(parent_process_id) {
|
|
std::process::exit(1);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
#[cfg(unix)]
|
|
fn is_process_active(process_id: u32) -> bool {
|
|
// TODO(bartlomieju):
|
|
#[allow(clippy::undocumented_unsafe_blocks)]
|
|
unsafe {
|
|
// signal of 0 checks for the existence of the process id
|
|
libc::kill(process_id as i32, 0) == 0
|
|
}
|
|
}
|
|
|
|
#[cfg(windows)]
|
|
fn is_process_active(process_id: u32) -> bool {
|
|
use winapi::shared::minwindef::DWORD;
|
|
use winapi::shared::minwindef::FALSE;
|
|
use winapi::shared::ntdef::NULL;
|
|
use winapi::shared::winerror::WAIT_TIMEOUT;
|
|
use winapi::um::handleapi::CloseHandle;
|
|
use winapi::um::processthreadsapi::OpenProcess;
|
|
use winapi::um::synchapi::WaitForSingleObject;
|
|
use winapi::um::winnt::SYNCHRONIZE;
|
|
|
|
// SAFETY: winapi calls
|
|
unsafe {
|
|
let process = OpenProcess(SYNCHRONIZE, FALSE, process_id as DWORD);
|
|
let result = if process == NULL {
|
|
false
|
|
} else {
|
|
WaitForSingleObject(process, 0) == WAIT_TIMEOUT
|
|
};
|
|
CloseHandle(process);
|
|
result
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::is_process_active;
|
|
use std::process::Command;
|
|
use test_util::deno_exe_path;
|
|
|
|
#[test]
|
|
fn process_active() {
|
|
// launch a long running process
|
|
let mut child = Command::new(deno_exe_path()).arg("lsp").spawn().unwrap();
|
|
|
|
let pid = child.id();
|
|
assert!(is_process_active(pid));
|
|
child.kill().unwrap();
|
|
child.wait().unwrap();
|
|
assert!(!is_process_active(pid));
|
|
}
|
|
}
|