1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
denoland-deno/ext/napi
Leo Kettmeir cf49599359
feat: permission stack traces in ops (#26938)
This commit improves permission prompts by adding an option
to print a full trace of where the permissions is being requested.

Due to big performance hint of stack trace collection, this is only
enabled when `DENO_TRACE_PERMISSIONS` env var is present.

Closes https://github.com/denoland/deno/issues/20756

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2024-11-20 21:24:04 +00:00
..
sym chore: forward v2.0.6 release commit to main (#26804) 2024-11-10 13:12:18 +05:30
build.rs feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
Cargo.toml chore: forward v2.0.6 release commit to main (#26804) 2024-11-10 13:12:18 +05:30
function.rs Reland "fix: CFunctionInfo and CTypeInfo leaks (#24634)" (#24692) 2024-07-24 02:11:38 +02:00
generated_symbol_exports_list_linux.def feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
generated_symbol_exports_list_macos.def feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
generated_symbol_exports_list_windows.def feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
js_native_api.rs feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
lib.rs feat: permission stack traces in ops (#26938) 2024-11-20 21:24:04 +00:00
node_api.rs fix: otel resiliency (#26857) 2024-11-14 12:16:28 +00:00
README.md feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
util.rs feat: support node-api in denort (#26389) 2024-10-24 09:13:54 +02:00
uv.rs fix: otel resiliency (#26857) 2024-11-14 12:16:28 +00:00
value.rs fix: clean up some node-api details (#24178) 2024-06-11 17:40:44 -07:00

napi

This directory contains source for Deno's Node-API implementation. It depends on napi_sym and deno_napi.

Files are generally organized the same as in Node.js's implementation to ease in ensuring compatibility.

Adding a new function

Add the symbol name to cli/napi_sym/symbol_exports.json.

{
  "symbols": [
    ...
    "napi_get_undefined",
-   "napi_get_null"
+   "napi_get_null",
+   "napi_get_boolean"
  ]
}

Determine where to place the implementation. napi_get_boolean is related to JS values so we will place it in js_native_api.rs. If something is not clear, just create a new file module.

See napi_sym for writing the implementation:

#[napi_sym::napi_sym]
fn napi_get_boolean(
  env: *mut Env,
  value: bool,
  result: *mut napi_value,
) -> Result {
  // ...
  Ok(())
}

Update the generated symbol lists using the script:

deno run --allow-write tools/napi/generate_symbols_lists.js

Add a test in /tests/napi. You can also refer to Node.js test suite for Node-API.

// tests/napi/boolean_test.js
import { assertEquals, loadTestLibrary } from "./common.js";
const lib = loadTestLibrary();
Deno.test("napi get boolean", function () {
  assertEquals(lib.test_get_boolean(true), true);
  assertEquals(lib.test_get_boolean(false), false);
});
// tests/napi/src/boolean.rs

use napi_sys::Status::napi_ok;
use napi_sys::ValueType::napi_boolean;
use napi_sys::*;

extern "C" fn test_boolean(
  env: napi_env,
  info: napi_callback_info,
) -> napi_value {
  let (args, argc, _) = crate::get_callback_info!(env, info, 1);
  assert_eq!(argc, 1);

  let mut ty = -1;
  assert!(unsafe { napi_typeof(env, args[0], &mut ty) } == napi_ok);
  assert_eq!(ty, napi_boolean);

  // Use napi_get_boolean here...

  value
}

pub fn init(env: napi_env, exports: napi_value) {
  let properties = &[crate::new_property!(env, "test_boolean\0", test_boolean)];

  unsafe {
    napi_define_properties(env, exports, properties.len(), properties.as_ptr())
  };
}
// tests/napi/src/lib.rs

+ mod boolean;

...

#[no_mangle]
unsafe extern "C" fn napi_register_module_v1(
  env: napi_env,
  exports: napi_value,
) -> napi_value {
  ...
+ boolean::init(env, exports);

  exports
}

Run the test using cargo test -p tests/napi.