mirror of
https://github.com/denoland/deno.git
synced 2024-11-21 15:04:11 -05:00
084eafe508
Max rps without a signal is unchanged, however we can drastically reduce memory usage by not creating the signal until needed, and we can optimize the rps in the case where the signal is created. With a quick memory benchmark, it looks like this helps pretty drastically with # of GCs when benchmarking w/wrk: - 1.42.4: 1763 - canary: 1093 - this patch: 874 This branch: ``` Running 10s test @ http://localhost:8080/ 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 87.33us 439.95us 20.68ms 99.67% Req/Sec 66.70k 6.39k 74.11k 83.66% 1340255 requests in 10.10s, 191.73MB read Requests/sec: 132696.90 Transfer/sec: 18.98MB cpu: Apple M2 Pro runtime: deno 1.43.0 (aarch64-apple-darwin) file:///Users/matt/Documents/scripts/bench_request.js benchmark time (avg) iter/s (min … max) p75 p99 p995 ----------------------------------------------------------------------------------------------- ----------------------------- newRequest 986.5 ns/iter 1,013,682.6 (878.2 ns … 1.18 µs) 1.01 µs 1.18 µs 1.18 µs newAbortController 18 ns/iter 55,541,104.1 (15.6 ns … 42.62 ns) 17.71 ns 25.05 ns 26.27 ns newAbortControllerSignal 18.66 ns/iter 53,578,966.7 (16.49 ns … 32.16 ns) 18.71 ns 25.67 ns 26.39 ns newAbortControllerSignalOnAbort 106.49 ns/iter 9,390,164.9 (97.87 ns … 120.61 ns) 108.6 ns 114.24 ns 115.89 ns newAbortControllerSignalAddEventListener 86.92 ns/iter 11,504,880.2 (81.88 ns … 103.15 ns) 90 ns 98.28 ns 99.55 ns newAbortControllerSignalOnAbortNoListener 3.01 µs/iter 331,964.4 (2.97 µs … 3.1 µs) 3.06 µs 3.1 µs 3.1 µs newAbortControllerSignalOnAbortAbort 3.26 µs/iter 306,662.6 (3.22 µs … 3.36 µs) 3.27 µs 3.36 µs 3.36 µs ``` Latest canary: ``` Running 10s test @ http://localhost:8080/ 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 72.86us 71.23us 4.47ms 99.05% Req/Sec 64.66k 5.54k 72.48k 82.18% 1299015 requests in 10.10s, 185.83MB read Requests/sec: 128616.02 Transfer/sec: 18.40MB cpu: Apple M2 Pro runtime: deno 1.43.0+bc4aa5f (aarch64-apple-darwin) file:///Users/matt/Documents/scripts/bench_request.js benchmark time (avg) iter/s (min … max) p75 p99 p995 ----------------------------------------------------------------------------------------------- ----------------------------- newRequest 1.25 µs/iter 800,005.2 (1.01 µs … 4.18 µs) 1.16 µs 4.18 µs 4.18 µs newAbortController 18.56 ns/iter 53,868,204.3 (16.04 ns … 38.73 ns) 18.38 ns 26.1 ns 26.63 ns newAbortControllerSignal 18.72 ns/iter 53,430,746.1 (16.13 ns … 36.71 ns) 18.71 ns 26.19 ns 26.98 ns newAbortControllerSignalOnAbort 193.91 ns/iter 5,156,992.4 (184.25 ns … 211.41 ns) 194.96 ns 207.87 ns 209.4 ns newAbortControllerSignalAddEventListener 171.45 ns/iter 5,832,569.2 (153 ns … 182.03 ns) 176.17 ns 180.75 ns 181.05 ns newAbortControllerSignalOnAbortNoListener 3.07 µs/iter 326,263.3 (2.98 µs … 3.17 µs) 3.08 µs 3.17 µs 3.17 µs newAbortControllerSignalOnAbortAbort 3.32 µs/iter 301,344.6 (3.29 µs … 3.4 µs) 3.33 µs 3.4 µs 3.4 µs ```
368 lines
9.9 KiB
JavaScript
368 lines
9.9 KiB
JavaScript
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
|
|
// @ts-check
|
|
/// <reference path="../../core/internal.d.ts" />
|
|
|
|
import { primordials } from "ext:core/mod.js";
|
|
const {
|
|
ArrayPrototypeEvery,
|
|
ArrayPrototypePush,
|
|
FunctionPrototypeApply,
|
|
ObjectPrototypeIsPrototypeOf,
|
|
SafeSet,
|
|
SafeSetIterator,
|
|
SafeWeakRef,
|
|
SafeWeakSet,
|
|
SetPrototypeAdd,
|
|
SetPrototypeDelete,
|
|
Symbol,
|
|
SymbolFor,
|
|
TypeError,
|
|
WeakRefPrototypeDeref,
|
|
WeakSetPrototypeAdd,
|
|
WeakSetPrototypeHas,
|
|
} = primordials;
|
|
|
|
import * as webidl from "ext:deno_webidl/00_webidl.js";
|
|
import { assert } from "./00_infra.js";
|
|
import { createFilteredInspectProxy } from "ext:deno_console/01_console.js";
|
|
import {
|
|
defineEventHandler,
|
|
Event,
|
|
EventTarget,
|
|
listenerCount,
|
|
setIsTrusted,
|
|
} from "./02_event.js";
|
|
import { refTimer, setTimeout, unrefTimer } from "./02_timers.js";
|
|
|
|
// Since WeakSet is not a iterable, WeakRefSet class is provided to store and
|
|
// iterate objects.
|
|
// To create an AsyncIterable using GeneratorFunction in the internal code,
|
|
// there are many primordial considerations, so we simply implement the
|
|
// toArray method.
|
|
class WeakRefSet {
|
|
#weakSet = new SafeWeakSet();
|
|
#refs = [];
|
|
|
|
add(value) {
|
|
if (WeakSetPrototypeHas(this.#weakSet, value)) {
|
|
return;
|
|
}
|
|
WeakSetPrototypeAdd(this.#weakSet, value);
|
|
ArrayPrototypePush(this.#refs, new SafeWeakRef(value));
|
|
}
|
|
|
|
has(value) {
|
|
return WeakSetPrototypeHas(this.#weakSet, value);
|
|
}
|
|
|
|
toArray() {
|
|
const ret = [];
|
|
for (let i = 0; i < this.#refs.length; ++i) {
|
|
const value = WeakRefPrototypeDeref(this.#refs[i]);
|
|
if (value !== undefined) {
|
|
ArrayPrototypePush(ret, value);
|
|
}
|
|
}
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
const add = Symbol("[[add]]");
|
|
const signalAbort = Symbol("[[signalAbort]]");
|
|
const remove = Symbol("[[remove]]");
|
|
const abortReason = Symbol("[[abortReason]]");
|
|
const abortAlgos = Symbol("[[abortAlgos]]");
|
|
const dependent = Symbol("[[dependent]]");
|
|
const sourceSignals = Symbol("[[sourceSignals]]");
|
|
const dependentSignals = Symbol("[[dependentSignals]]");
|
|
const signal = Symbol("[[signal]]");
|
|
const timerId = Symbol("[[timerId]]");
|
|
|
|
const illegalConstructorKey = Symbol("illegalConstructorKey");
|
|
|
|
class AbortSignal extends EventTarget {
|
|
[abortReason] = undefined;
|
|
[abortAlgos] = null;
|
|
[dependent] = false;
|
|
[sourceSignals] = null;
|
|
[dependentSignals] = null;
|
|
[timerId] = null;
|
|
[webidl.brand] = webidl.brand;
|
|
|
|
static any(signals) {
|
|
const prefix = "Failed to execute 'AbortSignal.any'";
|
|
webidl.requiredArguments(arguments.length, 1, prefix);
|
|
return createDependentAbortSignal(signals, prefix);
|
|
}
|
|
|
|
static abort(reason = undefined) {
|
|
if (reason !== undefined) {
|
|
reason = webidl.converters.any(reason);
|
|
}
|
|
const signal = new AbortSignal(illegalConstructorKey);
|
|
signal[signalAbort](reason);
|
|
return signal;
|
|
}
|
|
|
|
static timeout(millis) {
|
|
const prefix = "Failed to execute 'AbortSignal.timeout'";
|
|
webidl.requiredArguments(arguments.length, 1, prefix);
|
|
millis = webidl.converters["unsigned long long"](
|
|
millis,
|
|
prefix,
|
|
"Argument 1",
|
|
{
|
|
enforceRange: true,
|
|
},
|
|
);
|
|
|
|
const signal = new AbortSignal(illegalConstructorKey);
|
|
signal[timerId] = setTimeout(
|
|
() => {
|
|
signal[timerId] = null;
|
|
signal[signalAbort](
|
|
new DOMException("Signal timed out.", "TimeoutError"),
|
|
);
|
|
},
|
|
millis,
|
|
);
|
|
unrefTimer(signal[timerId]);
|
|
return signal;
|
|
}
|
|
|
|
[add](algorithm) {
|
|
if (this.aborted) {
|
|
return;
|
|
}
|
|
this[abortAlgos] ??= new SafeSet();
|
|
SetPrototypeAdd(this[abortAlgos], algorithm);
|
|
}
|
|
|
|
[signalAbort](
|
|
reason = new DOMException("The signal has been aborted", "AbortError"),
|
|
) {
|
|
if (this.aborted) {
|
|
return;
|
|
}
|
|
this[abortReason] = reason;
|
|
const algos = this[abortAlgos];
|
|
this[abortAlgos] = null;
|
|
|
|
if (listenerCount(this, "abort") > 0) {
|
|
const event = new Event("abort");
|
|
setIsTrusted(event, true);
|
|
super.dispatchEvent(event);
|
|
}
|
|
if (algos !== null) {
|
|
for (const algorithm of new SafeSetIterator(algos)) {
|
|
algorithm();
|
|
}
|
|
}
|
|
|
|
if (this[dependentSignals] !== null) {
|
|
const dependentSignalArray = this[dependentSignals].toArray();
|
|
for (let i = 0; i < dependentSignalArray.length; ++i) {
|
|
const dependentSignal = dependentSignalArray[i];
|
|
dependentSignal[signalAbort](reason);
|
|
}
|
|
}
|
|
}
|
|
|
|
[remove](algorithm) {
|
|
this[abortAlgos] && SetPrototypeDelete(this[abortAlgos], algorithm);
|
|
}
|
|
|
|
constructor(key = null) {
|
|
if (key !== illegalConstructorKey) {
|
|
throw new TypeError("Illegal constructor.");
|
|
}
|
|
super();
|
|
}
|
|
|
|
get aborted() {
|
|
webidl.assertBranded(this, AbortSignalPrototype);
|
|
return this[abortReason] !== undefined;
|
|
}
|
|
|
|
get reason() {
|
|
webidl.assertBranded(this, AbortSignalPrototype);
|
|
return this[abortReason];
|
|
}
|
|
|
|
throwIfAborted() {
|
|
webidl.assertBranded(this, AbortSignalPrototype);
|
|
if (this[abortReason] !== undefined) {
|
|
throw this[abortReason];
|
|
}
|
|
}
|
|
|
|
// `addEventListener` and `removeEventListener` have to be overridden in
|
|
// order to have the timer block the event loop while there are listeners.
|
|
// `[add]` and `[remove]` don't ref and unref the timer because they can
|
|
// only be used by Deno internals, which use it to essentially cancel async
|
|
// ops which would block the event loop.
|
|
addEventListener() {
|
|
FunctionPrototypeApply(super.addEventListener, this, arguments);
|
|
if (listenerCount(this, "abort") > 0) {
|
|
if (this[timerId] !== null) {
|
|
refTimer(this[timerId]);
|
|
} else if (this[sourceSignals] !== null) {
|
|
const sourceSignalArray = this[sourceSignals].toArray();
|
|
for (let i = 0; i < sourceSignalArray.length; ++i) {
|
|
const sourceSignal = sourceSignalArray[i];
|
|
if (sourceSignal[timerId] !== null) {
|
|
refTimer(sourceSignal[timerId]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
removeEventListener() {
|
|
FunctionPrototypeApply(super.removeEventListener, this, arguments);
|
|
if (listenerCount(this, "abort") === 0) {
|
|
if (this[timerId] !== null) {
|
|
unrefTimer(this[timerId]);
|
|
} else if (this[sourceSignals] !== null) {
|
|
const sourceSignalArray = this[sourceSignals].toArray();
|
|
for (let i = 0; i < sourceSignalArray.length; ++i) {
|
|
const sourceSignal = sourceSignalArray[i];
|
|
if (sourceSignal[timerId] !== null) {
|
|
// Check that all dependent signals of the timer signal do not have listeners
|
|
if (
|
|
ArrayPrototypeEvery(
|
|
sourceSignal[dependentSignals].toArray(),
|
|
(dependentSignal) =>
|
|
dependentSignal === this ||
|
|
listenerCount(dependentSignal, "abort") === 0,
|
|
)
|
|
) {
|
|
unrefTimer(sourceSignal[timerId]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
[SymbolFor("Deno.privateCustomInspect")](inspect, inspectOptions) {
|
|
return inspect(
|
|
createFilteredInspectProxy({
|
|
object: this,
|
|
evaluate: ObjectPrototypeIsPrototypeOf(AbortSignalPrototype, this),
|
|
keys: [
|
|
"aborted",
|
|
"reason",
|
|
"onabort",
|
|
],
|
|
}),
|
|
inspectOptions,
|
|
);
|
|
}
|
|
}
|
|
defineEventHandler(AbortSignal.prototype, "abort");
|
|
|
|
webidl.configureInterface(AbortSignal);
|
|
const AbortSignalPrototype = AbortSignal.prototype;
|
|
|
|
class AbortController {
|
|
[signal] = new AbortSignal(illegalConstructorKey);
|
|
|
|
constructor() {
|
|
this[webidl.brand] = webidl.brand;
|
|
}
|
|
|
|
get signal() {
|
|
webidl.assertBranded(this, AbortControllerPrototype);
|
|
return this[signal];
|
|
}
|
|
|
|
abort(reason) {
|
|
webidl.assertBranded(this, AbortControllerPrototype);
|
|
this[signal][signalAbort](reason);
|
|
}
|
|
|
|
[SymbolFor("Deno.privateCustomInspect")](inspect, inspectOptions) {
|
|
return inspect(
|
|
createFilteredInspectProxy({
|
|
object: this,
|
|
evaluate: ObjectPrototypeIsPrototypeOf(AbortControllerPrototype, this),
|
|
keys: [
|
|
"signal",
|
|
],
|
|
}),
|
|
inspectOptions,
|
|
);
|
|
}
|
|
}
|
|
|
|
webidl.configureInterface(AbortController);
|
|
const AbortControllerPrototype = AbortController.prototype;
|
|
|
|
webidl.converters.AbortSignal = webidl.createInterfaceConverter(
|
|
"AbortSignal",
|
|
AbortSignal.prototype,
|
|
);
|
|
webidl.converters["sequence<AbortSignal>"] = webidl.createSequenceConverter(
|
|
webidl.converters.AbortSignal,
|
|
);
|
|
|
|
function newSignal() {
|
|
return new AbortSignal(illegalConstructorKey);
|
|
}
|
|
|
|
function createDependentAbortSignal(signals, prefix) {
|
|
signals = webidl.converters["sequence<AbortSignal>"](
|
|
signals,
|
|
prefix,
|
|
"Argument 1",
|
|
);
|
|
|
|
const resultSignal = new AbortSignal(illegalConstructorKey);
|
|
for (let i = 0; i < signals.length; ++i) {
|
|
const signal = signals[i];
|
|
if (signal[abortReason] !== undefined) {
|
|
resultSignal[abortReason] = signal[abortReason];
|
|
return resultSignal;
|
|
}
|
|
}
|
|
|
|
resultSignal[dependent] = true;
|
|
resultSignal[sourceSignals] = new WeakRefSet();
|
|
for (let i = 0; i < signals.length; ++i) {
|
|
const signal = signals[i];
|
|
if (!signal[dependent]) {
|
|
signal[dependentSignals] ??= new WeakRefSet();
|
|
resultSignal[sourceSignals].add(signal);
|
|
signal[dependentSignals].add(resultSignal);
|
|
} else {
|
|
const sourceSignalArray = signal[sourceSignals].toArray();
|
|
for (let j = 0; j < sourceSignalArray.length; ++j) {
|
|
const sourceSignal = sourceSignalArray[j];
|
|
assert(sourceSignal[abortReason] === undefined);
|
|
assert(!sourceSignal[dependent]);
|
|
|
|
if (resultSignal[sourceSignals].has(sourceSignal)) {
|
|
continue;
|
|
}
|
|
resultSignal[sourceSignals].add(sourceSignal);
|
|
sourceSignal[dependentSignals].add(resultSignal);
|
|
}
|
|
}
|
|
}
|
|
|
|
return resultSignal;
|
|
}
|
|
|
|
export {
|
|
AbortController,
|
|
AbortSignal,
|
|
AbortSignalPrototype,
|
|
add,
|
|
createDependentAbortSignal,
|
|
newSignal,
|
|
remove,
|
|
signalAbort,
|
|
timerId,
|
|
};
|