foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-29 10:39:10 -05:00
Code Issues Packages 1 Wiki Activity
denoland-deno/cli/ops
History
Divy Srivastava de28e6fc09
refactor: add deno_permissions crate (#22236) 
Issue https://github.com/denoland/deno/issues/22222


![image](https://github.com/denoland/deno/assets/34997667/2af8474b-b919-4519-98ce-9d29bc7829f2)

This PR moves `runtime/permissions` code to a upstream crate called
`deno_permissions`. The `deno_permissions::PermissionsContainer` is put
into the OpState and can be used instead of the current trait-based
permissions system.

For this PR, I've migrated `deno_fetch` to the new crate but kept the
rest of the trait-based system as a wrapper of `deno_permissions` crate.
Doing the migration all at once is error prone and hard to review.

Comparing incremental compile times for `ext/fetch` on Mac M1:

| profile | `cargo build --bin deno` | `cargo plonk build --bin deno` |
| --------- | ------------- | ------------------- |
| `debug`   | 20 s          | 0.8s                |
| `release` | 4 mins 12 s   | 1.4s                  |
2024-03-12 10:42:26 -07:00
..
bench.rs refactor: add deno_permissions crate (#22236) 2024-03-12 10:42:26 -07:00
jupyter.rs chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00
mod.rs chore: update copyright to 2024 (#21753) 2024-01-01 19:58:21 +00:00
testing.rs refactor: add deno_permissions crate (#22236) 2024-03-12 10:42:26 -07:00