denoland-deno

mirror of https://github.com/denoland/deno.git synced 2024-10-30 09:08:00 -04:00

History

Evan Hahn f5c0188b5e std/node: add util.callbackify (#5415 ) This adds [Node's `util.callbackify`][0] to `std/node/util.ts`. I lifted most of this from the [original Node source code][1] (and [its tests][2]). I tried to make minimal modifications to the source. I made a few arbitrary decisions: - I was unable to do the function's types elegantly. I made overloads for functions that have 0 to 5 (inclusive) arguments, excluding the callback. I would love to know a better way to do this. (It seems that the folks at DefinitelyTyped [were also stumped][3], though maybe their solution is deliberate.) - There are a few edge cases that cause custom Node errors to be produced. Instead of re-implementing those errors completely, I created simplified classes. These are mostly correct but are not identical to the real Node errors. - The tests implement a possibly-arcane `TestQueue` class. I originally used a lot of inline promises but found it too repetitive. Closes [#5366][4]. [0]: https://nodejs.org/api/util.html#util_util_callbackify_original [1]: `4780493301/lib/util.js (L183-L226)` [2]: `4780493301/test/parallel/test-util-callbackify.js` [3]: `7d24857ddb/types/node/util.d.ts (L61-L84)` [4]: https://github.com/denoland/deno/issues/5366	2020-05-20 10:29:05 -04:00
..
_util_callbackify.ts	std/node: add util.callbackify (#5415 )	2020-05-20 10:29:05 -04:00
_util_callbackify_test.ts	std/node: add util.callbackify (#5415 )	2020-05-20 10:29:05 -04:00

This adds [Node's `util.callbackify`][0] to `std/node/util.ts`.

I lifted most of this from the [original Node source code][1] (and [its
tests][2]). I tried to make minimal modifications to the source.

I made a few arbitrary decisions:

- I was unable to do the function's types elegantly. I made overloads
  for functions that have 0 to 5 (inclusive) arguments, excluding the
  callback. I would love to know a better way to do this. (It seems that
  the folks at DefinitelyTyped [were also stumped][3], though maybe
  their solution is deliberate.)
- There are a few edge cases that cause custom Node errors to be
  produced. Instead of re-implementing those errors completely, I
  created simplified classes. These are mostly correct but are not
  identical to the real Node errors.
- The tests implement a possibly-arcane `TestQueue` class. I originally
  used a lot of inline promises but found it too repetitive.

Closes [#5366][4].

[0]: https://nodejs.org/api/util.html#util_util_callbackify_original
[1]: 4780493301/lib/util.js (L183-L226)
[2]: 4780493301/test/parallel/test-util-callbackify.js
[3]: 7d24857ddb/types/node/util.d.ts (L61-L84)
[4]: https://github.com/denoland/deno/issues/5366

2020-05-20 10:29:05 -04:00

_util_callbackify.ts std/node: add util.callbackify (#5415 ) 2020-05-20 10:29:05 -04:00

_util_callbackify_test.ts std/node: add util.callbackify (#5415 ) 2020-05-20 10:29:05 -04:00