0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-30 09:08:00 -04:00
denoland-deno/ext
Marvin Hagemeister f5c1ff08e6
fix(node): map stdio [0, 1, 2] to "inherit" (#19352)
<!--
Before submitting a PR, please read https://deno.com/manual/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
Internally, `node-tap` spawns a child process with `stdio: [0, 1, 2]`.
Whilst we don't support passing fd numbers as an argument so far, it
turns out that `[0, 1, 2]` is equivalent to `"inherit"` which we already
support. See: https://nodejs.org/api/child_process.html#optionsstdio

Mapping it to `"inherit"` is fine for us and gets us one step closer in
getting `node-tap` working. I'm now at the stage where already the
coverage table is shown 🎉
2023-06-02 09:46:50 -06:00
..
broadcast_channel chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
cache chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
console chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
crypto chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
fetch chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
ffi chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
fs chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
http chore(ext/http): add env var to disable writev syscall (#19338) 2023-06-01 08:07:26 -06:00
io chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
kv chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
napi chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
net chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
node fix(node): map stdio [0, 1, 2] to "inherit" (#19352) 2023-06-02 09:46:50 -06:00
tls chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
url chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
web refactor: further work on node http client (#19327) 2023-05-31 20:06:21 +02:00
webidl chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
websocket chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00
webstorage chore: forward v1.34.1 to main (#19312) 2023-05-29 20:26:03 -06:00