mirror of
https://github.com/denoland/deno.git
synced 2024-12-22 07:14:47 -05:00
275418473e
Fixes #25998. Fixes https://github.com/denoland/deno/issues/25928. Originally I was just going to make this an error message instead of a panic, but once I got to a minimal repro I felt that this really should work. The panic occurs when you have `nodeModulesDir: manual` (or a package.json present), and you have an npm package with a tag in your deno.json (see the spec test that illustrates this). This code path only actually executes when trying to choose an appropriate package version from `node_modules/.deno`, so we should be able to fix it by storing some extra data at install time. The fix proposed here is to repurpose the `.initialized` file that we store in `node_modules` to store the tags associated with a package. Basically, if you have a version requirement with a tag (e.g. `npm:chalk@latest`), when we set up the node_modules folder for that package, we store the tag (`latest`) in `.initialized`. Then, when doing BYONM resolution, if we have a version requirement with a tag, we read that file and check if the tag is present. The downside is that we do more work when setting up `node_modules`. We _could_ do this only when BYONM is enabled, but that would have the downside of needing to re-run `deno install` when you switch from auto -> manual, though maybe that's not a big deal. |
||
|---|---|---|
| .. | ||
| config | ||
| ffi | ||
| integration | ||
| napi | ||
| node_compat | ||
| registry | ||
| specs | ||
| testdata | ||
| unit | ||
| unit_node | ||
| util | ||
| wpt | ||
| Cargo.toml | ||
| lib.rs | ||
| README.md | ||