denoland-deno/ext/node/polyfills/00_globals.js at fe5822503604d4df1ebd3202029faf0e3ac15d7d - foster/denoland-deno - Foster's Laboratory

foster/denoland-deno

mirror of https://github.com/denoland/deno.git synced 2024-11-30 16:40:57 -05:00

Luca Casonato e511022c74

feat(ext/node): properly segregate node globals (#19307 )

Code run within Deno-mode and Node-mode should have access to a
slightly different set of globals. Previously this was done through a
compile time code-transform for Node-mode, but this is not ideal and has
many edge cases, for example Node's globalThis having a different
identity than Deno's globalThis.

This commit makes the `globalThis` of the entire runtime a semi-proxy.
This proxy returns a different set of globals depending on the caller's
mode. This is not a full proxy, because it is shadowed by "real"
properties on globalThis. This is done to avoid the overhead of a full
proxy for all globalThis operations.

The globals between Deno-mode and Node-mode are now properly segregated.
This means that code running in Deno-mode will not have access to Node's
globals, and vice versa. Deleting a managed global in Deno-mode will
NOT delete the corresponding global in Node-mode, and vice versa.

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>

2023-07-19 10:30:04 +02:00

6 lines

246 B

JavaScript

Raw Blame History

 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
 // deno-lint-ignore-file
 export const denoGlobals = globalThis.__bootstrap.ext_node_denoGlobals;
 export const nodeGlobals = globalThis.__bootstrap.ext_node_nodeGlobals;