From 0654d2248a5e65c2294bdbe5a7db076be01ce5ed Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Fri, 27 Oct 2023 10:00:49 -0600 Subject: [PATCH] chore: disable zlib in rusty_v8 (#1358) --- .gn | 5 ++++- third_party/zlib | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) delete mode 160000 third_party/zlib diff --git a/.gn b/.gn index 55dece74..47e858e6 100644 --- a/.gn +++ b/.gn @@ -31,12 +31,15 @@ default_args = { use_debug_fission = false v8_enable_sandbox = false - v8_enable_snapshot_compression = false v8_enable_javascript_promise_hooks = true v8_promise_internal_field_count = 1 v8_use_external_startup_data = false v8_use_snapshot = true + # We prefer embedders to bring their own compression + v8_use_zlib = false + v8_enable_snapshot_compression = false + # Disable handle zapping for performance v8_enable_handle_zapping = false # Ensure allocation of typed arrays and arraybuffers always goes through diff --git a/third_party/zlib b/third_party/zlib deleted file mode 160000 index 18d27fa1..00000000 --- a/third_party/zlib +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 18d27fa10b237fdfcbd8f0c65c19fe009981a3bc