From 21a8d4a580dc62940826efee5985ffc32815019d Mon Sep 17 00:00:00 2001 From: denobot <33910674+denobot@users.noreply.github.com> Date: Mon, 25 Jul 2022 10:22:32 -0700 Subject: [PATCH] Rolling to V8 10.5.218.1 (#1036) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Bartek Iwańczuk --- README.md | 2 +- build.rs | 2 +- tests/test_api.rs | 14 +++++++++++++- v8 | 2 +- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 971b7f4e..1abe2c45 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Rusty V8 Binding -V8 Version: 10.4.132.20 +V8 Version: 10.5.218.1 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions) [![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8) diff --git a/build.rs b/build.rs index 55ff5b44..27f63aad 100644 --- a/build.rs +++ b/build.rs @@ -748,7 +748,7 @@ fn rerun_if_changed(out_dir: &Path, maybe_env: Option, target: &str) { let deps = ninja_get_deps(out_dir, maybe_env, target); for d in deps { let p = out_dir.join(d); - assert!(p.exists()); + assert!(p.exists(), "Path doesn't exist: {:?}", p); println!("cargo:rerun-if-changed={}", p.display()); } } diff --git a/tests/test_api.rs b/tests/test_api.rs index dad69e6f..462e4c75 100644 --- a/tests/test_api.rs +++ b/tests/test_api.rs @@ -37,7 +37,7 @@ fn setup() -> SetupGuard { )) .is_ok()); v8::V8::set_flags_from_string( - "--expose_gc --harmony-import-assertions --harmony-shadow-realm --allow_natives_syntax --turbo_fast_api_calls", + "--no_freeze_flags_after_init --expose_gc --harmony-import-assertions --harmony-shadow-realm --allow_natives_syntax --turbo_fast_api_calls", ); v8::V8::initialize_platform( v8::new_default_platform(0, false).make_shared(), @@ -5703,6 +5703,13 @@ fn wasm_streaming_callback() { ws.finish(); assert!(!scope.has_pending_background_tasks()); + assert!(global.get(scope, name).unwrap().is_null()); + + while v8::Platform::pump_message_loop( + &v8::V8::get_current_platform(), + scope, + false, // don't block if there are no tasks + ) {} // We did not set wasm resolve callback so V8 uses the default one that // runs microtasks automatically. @@ -5729,6 +5736,11 @@ fn wasm_streaming_callback() { ws.abort(Some(exception)); // We did not set wasm resolve callback so V8 uses the default one that // runs microtasks automatically. + while v8::Platform::pump_message_loop( + &v8::V8::get_current_platform(), + scope, + false, // don't block if there are no tasks + ) {} assert!(global.get(scope, name).unwrap().strict_equals(exception)); } diff --git a/v8 b/v8 index 8d0f7db9..d50c91cc 160000 --- a/v8 +++ b/v8 @@ -1 +1 @@ -Subproject commit 8d0f7db90d8cbb4ee9ddf05ecceccbb0ecc549b7 +Subproject commit d50c91cc9e5baab72fd876b7c05acb002810e0d6