foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-11 16:42:32 -05:00
Code Issues Activity

build: upgrade Rust to 1.50.0 (#645)

Browse source
This commit is contained in:
Ben Noordhuis 2021-03-16 21:05:14 +01:00 committed by GitHub
parent a71575af81
commit 25608cc000
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View file

@ -69,7 +69,7 @@ jobs:
uses: hecrj/setup-rust-action@v1 uses: hecrj/setup-rust-action@v1
with: with:
components: clippy, rustfmt components: clippy, rustfmt
rust-version: 1.49.0 rust-version: 1.50.0
- name: Install python - name: Install python
uses: actions/setup-python@v1 uses: actions/setup-python@v1

11
tests/test_api.rs
View file

@ -2007,6 +2007,9 @@ fn module_instantiation_failures1() {
} }
} }
// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn compile_specifier_as_module_resolve_callback<'a>( fn compile_specifier_as_module_resolve_callback<'a>(
context: v8::Local<'a, v8::Context>, context: v8::Local<'a, v8::Context>,
specifier: v8::Local<'a, v8::String>, specifier: v8::Local<'a, v8::String>,
@ -2066,6 +2069,9 @@ fn import_assertions() {
let _setup_guard = setup(); let _setup_guard = setup();
let isolate = &mut v8::Isolate::new(Default::default()); let isolate = &mut v8::Isolate::new(Default::default());
// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn module_resolve_callback<'a>( fn module_resolve_callback<'a>(
context: v8::Local<'a, v8::Context>, context: v8::Local<'a, v8::Context>,
_specifier: v8::Local<'a, v8::String>, _specifier: v8::Local<'a, v8::String>,
@ -3556,7 +3562,7 @@ fn take_heap_snapshot() {
true true
}); });
let s = std::str::from_utf8(&vec).unwrap(); let s = std::str::from_utf8(&vec).unwrap();
assert!(s.find(r#""Eyecatcher""#).is_some()); assert!(s.contains("Eyecatcher"));
} }
} }
@ -3875,6 +3881,9 @@ fn low_memory_notification() {
isolate.low_memory_notification(); isolate.low_memory_notification();
} }
// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn synthetic_evaluation_steps<'a>( fn synthetic_evaluation_steps<'a>(
context: v8::Local<'a, v8::Context>, context: v8::Local<'a, v8::Context>,
module: v8::Local<v8::Module>, module: v8::Local<v8::Module>,